Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3545 closed defect (fixed)

mythmusic not playing complete .flac files when compiled with flac-1.1.4

Reported by: anonymous Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythmusic Version: 0.20-fixes
Severity: medium Keywords: mythmusic flac
Cc: Ticket locked: no

Description

upon attempting to play a .flac file, mythmusic plays *maybe* the first decoded frame, then moves on to the next file. this appears to happen because the flacdecoder isn't checking for some of the newer non-error status codes returned by the flac decoder lib in 1.1.4.

i've patched the flacdecoder.cpp file of mythmusic to take the new status codes into account. note: the patch is probably not compatible with much older versions of flac (probably needs some fine tuning based on flac api version).

Attachments (2)

mythmusic-flac-1.1.4.patch (1.3 KB) - added by james_defelice@… 12 years ago.
patch for flacdecoder.cpp
mythmusic_flac_decoder_state.diff (2.5 KB) - added by stuartm 12 years ago.
Patch which should work against 1.1.2

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by james_defelice@…

Attachment: mythmusic-flac-1.1.4.patch added

patch for flacdecoder.cpp

comment:1 Changed 12 years ago by stuartm

Owner: changed from Isaac Richards to stuartm
Status: newassigned

Changed 12 years ago by stuartm

Patch which should work against 1.1.2

comment:2 Changed 12 years ago by stuartm

Milestone: unknown0.21

Could you try the patch I've attached? It does the same as your patch but should build and work on systems with Flac 1.1.2 installed as well as those with 1.1.3. and 1.1.4.

comment:3 Changed 12 years ago by stuartm

Resolution: fixed
Status: assignedclosed

(In [13663]) Fixes playback with Flac 1.1.4 by accounting for some new decoder state codes. Based on a patch by James Defelice which I modified to work with older versions of Flac.

Thanks to everyone who confirmed that this did indeed build and work on versions 1.1.2 and 1.1.4

Closes #3545

comment:4 Changed 12 years ago by ijc@…

Hello,

Would it be possible to have this patch applied to the release-0.20-fixed branch? It applies cleanly for me here.

Many thanks, Ian.

comment:5 Changed 12 years ago by stuartm

(In [14089]) Backports [13663] Flac 1.1.4 support to -fixes.

Refs #3545

Note: See TracTickets for help on using tickets.