Opened 17 years ago
Closed 17 years ago
Last modified 17 years ago
#3545 closed defect (fixed)
mythmusic not playing complete .flac files when compiled with flac-1.1.4
Reported by: | anonymous | Owned by: | stuartm |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythmusic | Version: | 0.20-fixes |
Severity: | medium | Keywords: | mythmusic flac |
Cc: | Ticket locked: | no |
Description
upon attempting to play a .flac file, mythmusic plays *maybe* the first decoded frame, then moves on to the next file. this appears to happen because the flacdecoder isn't checking for some of the newer non-error status codes returned by the flac decoder lib in 1.1.4.
i've patched the flacdecoder.cpp file of mythmusic to take the new status codes into account. note: the patch is probably not compatible with much older versions of flac (probably needs some fine tuning based on flac api version).
Attachments (2)
Change History (7)
Changed 17 years ago by
Attachment: | mythmusic-flac-1.1.4.patch added |
---|
comment:1 Changed 17 years ago by
Owner: | changed from Isaac Richards to stuartm |
---|---|
Status: | new → assigned |
Changed 17 years ago by
Attachment: | mythmusic_flac_decoder_state.diff added |
---|
Patch which should work against 1.1.2
comment:2 Changed 17 years ago by
Milestone: | unknown → 0.21 |
---|
Could you try the patch I've attached? It does the same as your patch but should build and work on systems with Flac 1.1.2 installed as well as those with 1.1.3. and 1.1.4.
comment:3 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 Changed 17 years ago by
Hello,
Would it be possible to have this patch applied to the release-0.20-fixed branch? It applies cleanly for me here.
Many thanks, Ian.
patch for flacdecoder.cpp