Opened 13 years ago

Closed 11 years ago

#3568 closed patch (wontfix)

Building from lndir tree fails to install themes

Reported by: Derek Atkins <warlord@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I build mythtv from an lndir tree. I pull out myth from svn and store it in an NFS store and then use lndir on the various machines to build different configurations (e.g. different CPUs, etc). By using lndir I'm sure that I'm using the same source code for all the builds. However, building from an lndir tree, the themes fail to install properly, and then the mythfrontend crashes at startup.

The attached patch to cpsvndir fixes the problem and lets the themes get installed from an lndir tree.

Attachments (3)

myth-symlinks.diff (470 bytes) - added by Derek Atkins <warlord@…> 13 years ago.
myth-cpsvndir.patch (535 bytes) - added by sphery <mtdean@…> 12 years ago.
mythtv-cpsvndir.patch (658 bytes) - added by sphery <mtdean@…> 12 years ago.
Updated patch that works with the new version of cpsvndir

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by Derek Atkins <warlord@…>

Attachment: myth-symlinks.diff added

comment:1 Changed 12 years ago by sphery <mtdean@…>

The patch myth-symlinks.diff actually breaks installation (due to improper grouping) for those not using lndir. The attached patch, myth-cpsvndir.patch, actually works for links or files (i.e. whether using lndir or not).

Note that myth-cpsvndir.patch was created against cpsvndir in themes. In themes, it's actually necessary (currently) since some of the themes use links to "reuse" images. I don't know if Justin plans to change this, but most likely they will eventually be changed to remove the need for symlinks so that images aren't loaded multiple times.

The same patch can be applied to myththemes and mythtv's copies of cpsvndir, if desired, to support those using lndir installation.

Changed 12 years ago by sphery <mtdean@…>

Attachment: myth-cpsvndir.patch added

comment:2 Changed 12 years ago by Derek Atkins <warlord@…>

Yes, this new patch works for me, too. Sorry for the bad grouping.

Changed 12 years ago by sphery <mtdean@…>

Attachment: mythtv-cpsvndir.patch added

Updated patch that works with the new version of cpsvndir

comment:3 Changed 12 years ago by sphery <mtdean@…>

I updated the patch to work with the modifications that Nigel made to trunk/mythtv/themes/cpsvndir . The patch myth-cpsvndir.patch works for the cpsvndir in trunk/myththemes and trunk/themes , but if they are updated to reflect the changes made to trunk/mythtv/themes/cpsvndir , then mythtv-cpsvndir.patch should be used for all three.

comment:4 Changed 12 years ago by Nigel

(In [16511]) Update as per trunk versions [16487] [16491]. Also add copying of symlinks (Indir tree). See #3568. (did slightly differently to Michael T. Dean's patch)

comment:5 Changed 12 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [16512]) Add copying of symlinks (Indir tree). Closes #3568. (did slightly differently to Michael T. Dean's patch)

comment:6 Changed 12 years ago by Derek Atkins <warlord@…>

Resolution: fixed
Status: closednew

Unfortunately this patch appears not to have made it into the 0.21 release.

comment:7 Changed 11 years ago by danielk

Resolution: wontfix
Status: newclosed

feature added in trunk, not backporting this to 0.21

Note: See TracTickets for help on using tickets.