Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#36 closed patch (fixed)

mythvideo gallery filebrowsemode fix

Reported by: Robert Tsai <rtsai1111> Owned by: Isaac Richards
Priority: minor Milestone: 0.19
Component: mythvideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When MythVideo? gallery is configured for "filebrowser" mode, the zero-based array index of the file does not correspond to the 1-based (possibly sparsely-populated) "intid" values of the videos in the database.

However, in VideoSelected?, the "curitem", rather than being populated with the correct database data corresponding to the selected file, is instead populated with the database data whose "intid" value is equal to the array index.

This patch fixes that problem. When configured for "filebrowse" mode, this bug will probably manifest itself as an "off-by-one" bug (e.g., if you select some video from the video gallery, the next detail screen will present information for the immediately-preceding video).

It also looks like this VideoSelected? constructor will fail if a browsed file is not in the database. But I don't address that here.

Attachments (1)

mythvideo.setid.diff (420 bytes) - added by Robert Tsai <rtsai1111> 14 years ago.

Download all attachments as: .zip

Change History (2)

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythvideo.setid.diff added

comment:1 Changed 14 years ago by jdonavan

Resolution: fixed
Status: newclosed

(In [6761]) Patch from Robert Tsai to fix a index error when in file mode that would cause the VideoSelected? window to show the wrong info.

This closes #36

Note: See TracTickets for help on using tickets.