Opened 12 years ago

Closed 11 years ago

#3600 closed enhancement (fixed)

enhancement: tv osd menu editor.

Reported by: skamithi Owned by: skamithi
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

developing a way to remove/add osd entries from the tv osd menu.

there are 2 pieces to the patch, one of which is not done yet. first part is the db piece and tv_play.cpp modifications..2nd piece is the UI to change which osd menu entries shows up under which type of playbackable context. there are 4 categories. a) live tv b) recording/pre-precorded (may break this out into separate recording and prerecorded categories) c) video d) dvd

currently the db table looks like this:

  CREATE TABLE IF NOT EXISTS tvosdmenu (
         osdcategory VARCHAR(32) NOT NULL PRIMARY KEY,
         livetv tinyint(4) NOT NULL default '0',
         recorded tinyint(4) NOT NULL default '0',
         video tinyint(4) NOT NULL default '0',
         dvd tinyint(4) NOT NULL default '0',
         description varchar(32) NOT NULL


attached part is the part1 patch. to change any options you have to manipulate the tvosdmenu table directly. part2 is to create a UI to allow you to easily make the changes.

Attachments (3)

tv_osd_menu_editor_full.diff (72.9 KB) - added by skamithi 11 years ago.
patch for full feature from michael rice.
osd_menu_rev_20003.diff (53.3 KB) - added by skamithi 11 years ago.
complete osd menu editor patch.. against rev 20003. doesn't include dbcheck.cpp update
osd_menu_editor_db_check.diff (1.0 KB) - added by skamithi 11 years ago.
db_check.cpp patch

Download all attachments as: .zip

Change History (17)

comment:1 Changed 12 years ago by skamithi

Owner: changed from Isaac Richards to skamithi

comment:2 Changed 12 years ago by danielk

Version: unknownhead

Changed 11 years ago by skamithi

patch for full feature from michael rice.

comment:3 Changed 11 years ago by Dibblah

Status: newassigned

Changed 11 years ago by skamithi

Attachment: osd_menu_rev_20003.diff added

complete osd menu editor patch.. against rev 20003. doesn't include dbcheck.cpp update

Changed 11 years ago by skamithi

db_check.cpp patch

comment:4 Changed 11 years ago by skamithi

patches are ready for testing/review.i'll commit at the end of the week if there is no big issues with the patches.

comment:5 Changed 11 years ago by Matthew Wire <devel@…>

Seems to work as reported.

comment:6 Changed 11 years ago by wstewart@…

In libs/libmythtv/playercontext.cpp you detect a DVD by looking for dvd: for the watchingDVD state, I think you need to add ".iso" also to detect ISO dvd images

comment:7 Changed 11 years ago by skamithi

(In [20037]) Refs #3600. TV osd menu editor. helps declutter the tv osd menu. breaks osd menu options into 4 classes: live tv, recorded, video and dvd. osd menu editor is located in the setup->tv settings window

comment:8 Changed 11 years ago by skamithi

(In [20038]) Refs #3600. osd menu editor: forgot to include a check in mythosdmenueditor.cpp

comment:9 Changed 11 years ago by skamithi

(In [20042]) Refs #3600. addition to tv_play.cpp from the ticket patch that wasn't commited. updates TV::StateIsPlaying?.

comment:10 Changed 11 years ago by danielk

Manual Zoom Mode appears to be missing from the menu's now. Also when I tried removing all menu items except Manual Zoom Mode it appeared to cause a deadlock in the key handling code (in addition to not showing the OSD menu).

comment:11 Changed 11 years ago by skamithi

(In [20043]) Refs #3600. fix typo regarding manual zoom. reported by danielk.

comment:12 Changed 11 years ago by skamithi

i'll work on fixing the scenario where removing all menu items causes a deadlock.

comment:13 Changed 11 years ago by skamithi

(In [20044]) Refs #3600. prevent keyboard deadlock when all osd menu entries are unchecked.

comment:14 Changed 11 years ago by skamithi

Resolution: fixed
Status: assignedclosed

(In [20245]) Closes #3600. use the captive wrapstyle in the osdmenueditor UI buttonlists.

Note: See TracTickets for help on using tickets.