Opened 12 years ago

Closed 12 years ago

#3633 closed defect (fixed)

DSM-320 cannot play file by UPNP with 0.20 patch 11782

Reported by: anonymous Owned by: dblain
Priority: major Milestone: unknown
Component: mythtv Version: 0.20-fixes
Severity: medium Keywords: upnp content-length
Cc: Ticket locked: no

Description

Patch 11782 in 0.20 reduces the number of bytes sent to one less than requested. The DSM-320 does not like that and retries and refails forever. This patch is not in the trunk.

The number of bytes requested really is <last-byte-of-range> minus <first-byte-of-range> plus one. This change removed the "plus one".

The stated aim of 11782 is to "fix ... offbyone" which is wrong, and "infinite loop" which is unclear and not experienced by me :). If there is an infinite loop, then the fix must be somewhere else.

The fix is to remove patch 11782.

Attachments (1)

httprequest.patch (609 bytes) - added by anonymous 12 years ago.
Back out 11782

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by anonymous

Attachment: httprequest.patch added

Back out 11782

comment:1 Changed 12 years ago by robsbox@…

I took care of this in my patch -- see http://svn.mythtv.org/trac/ticket/3580

comment:2 in reply to:  1 Changed 12 years ago by anonymous

Replying to robsbox@optonline.net:

I took care of this in my patch -- see http://svn.mythtv.org/trac/ticket/3580

I assume that you are referring to the main line code, where this bad patch was not applied. The bad patch is only in the 0.20-fixes and 0.20.1 branch, where it is still a problem.

This is the branch included in Mythdora 4 and what every new user currently gets from the repos.

comment:3 Changed 12 years ago by dblain

Owner: changed from Isaac Richards to dblain

comment:4 Changed 12 years ago by dblain

Resolution: fixed
Status: newclosed

Fixed with r14268

Note: See TracTickets for help on using tickets.