Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#3641 closed patch (invalid)

Add MythWeb preview images to myth.find_orphans.pl -script

Reported by: otto at kolsi dot fi Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: contrib Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Attached patch adds two additional thumbnail images to myth.find_orphans.pl -script so that it recognizes those. These images are created by MythWeb.

I'm not sure if there are other sizes also, but these are the only ones present in my system.

Attachments (2)

preview-images.patch (502 bytes) - added by otto at kolsi dot fi 12 years ago.
myth.find_orphans-patch.new (887 bytes) - added by mythtv@… 10 years ago.
Revised patch using regex for .png files and also excluding sql backups

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by otto at kolsi dot fi

Attachment: preview-images.patch added

comment:1 in reply to:  description Changed 12 years ago by otto at kolsi dot fi

Replying to otto at kolsi dot fi:

I'm not sure if there are other sizes also, but these are the only ones present in my system.

Patch as it is should not be used. Regexp based matching is needed because there are at least following filename formats:

.100x0x89.png
.320x0x89.png
.100x0x155.png
.320x0x155.png
.100x0x185.png
.320x0x155.png

comment:2 Changed 12 years ago by stuartm

Status: newinfoneeded_new

This patch needs to be updated for trunk where the format has changed.

comment:3 Changed 12 years ago by stuartm

Resolution: invalid
Status: infoneeded_newclosed

Requested updated patch not provided, closing.

comment:4 Changed 12 years ago by sphery <mtdean@…>

If provided, patch should use a regex as in [16106] (line 335).

comment:5 Changed 12 years ago by otto at kolsi dot fi

Just a reminder for me or anyone else possibly looking into this.. patch should also take into account the DB backup files that now can be in recordings directory (e.g. mythconverg-1213-20080308094040.sql.gz).

Changed 10 years ago by mythtv@…

Attachment: myth.find_orphans-patch.new added

Revised patch using regex for .png files and also excluding sql backups

comment:6 Changed 10 years ago by mythtv@…

Note: bug has been reopened since I wrote a (trivial) patch to recognize mythweb style png thumbnails and to ignore the mythconverg sql backups.

Let me know if the regex I use doesn't catch all the png and sql backup names out there...

Note: See TracTickets for help on using tickets.