Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#37 closed patch (fixed)

mythgallery should use myth_system instead of system

Reported by: Robert Tsai <rtsai1111> Owned by: Isaac Richards
Priority: minor Milestone: 0.19
Component: mythgallery Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

mythgallery uses system("mplayer ...") to generate thumbnails for movie files.

This appears to cause some tty-related hangs from not closing stdin, etc. Recovering requires killing -9 mythfrontend, etc., which still leaves behind mplayer as a zombie.

Replacing these calls with myth_system makes the problem go away (and yields properly-generated thumbnails for movie files).

Attachments (1)

mythgallery.system.diff (1.4 KB) - added by Robert Tsai <rtsai1111> 14 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 years ago by Robert Tsai <rtsai1111>

Forget what I said about the zombies, they were actually wedged by gdb :).

But using system() still leaves mplayer hung waiting for stdin, and still requires kill -9 to recover.

comment:2 Changed 14 years ago by Robert Tsai <rtsai1111>

Type: defectpatch

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythgallery.system.diff added

comment:3 Changed 14 years ago by Robert Tsai <rtsai1111>

(I've verified that the thumbgallery.cpp fix works. The iconview.cpp changes are just for good measure; they shouldn't hurt, right?)

comment:4 Changed 14 years ago by jdonavan

Resolution: fixed
Status: newclosed

(In [6763]) Patch from Robert Tsai to use myth_system in place of system calls.

This closes #37

Note: See TracTickets for help on using tickets.