Opened 12 years ago

Closed 12 years ago

#3704 closed patch (fixed)

Mythmusic doesn't automatically go to fullscreen visual initially.

Reported by: anonymous Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When mythmusic is started, and one starts a song playing, mythmusic will not go to full screen visual automatically if set to do so. This occurs only if "SELECT" is the only key pressed. If one presses "SELECT" to choose the song to play, they presses another key say "SHUFFLE", then mythmusic will go to full screen visual automatically

This is because the "SELECT" action in keyPressEvent calls CycleVisualizer?(). CycleVisualizer? in turn calls visual_mode_timer-stop(). If one presses another key, any key other than "SELECT", keyPressEvent calls resetTimer which retarts the timer.

This patch changes the call to visual_mode_timer-stop() in CycleVisualizer?() to resetTimer instead.

Attachments (1)

mythmusic-autovis.patch (901 bytes) - added by maverik044 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by maverik044

Attachment: mythmusic-autovis.patch added

comment:1 Changed 12 years ago by paulh

Milestone: unknown0.21
Owner: changed from Isaac Richards to paulh
Type: enhancementpatch
Version: unknownhead

comment:2 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [14194]) Fix a bug in MythMusic where the automatic switching to the fullscreen visualizer wasn't working when the 'Change visualizer on each song' setting was on and the 'Select' key was pressed.

Patch by maverik044. Closes #3704.

Note: See TracTickets for help on using tickets.