Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 7 years ago

Closed 6 years ago

#3753 closed task (fixed)

Settings cleanup

Reported by: devel@… Owned by: nigel
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I'm creating this ticket to collate a number of small patches relating to settings dialogs in Mythtv

Attachments (5)

dbsettings-cleanup-180707.diff (4.5 KB) - added by devel@… 7 years ago.
Cleanup of database settings dialog
frontend-virtualkeyboard_and_menutheme-description-180707.diff (1.1 KB) - added by devel@… 7 years ago.
Virtual Keyboard, Menu theme descriptions
frontend-generalsettings-cleanup-180707.diff (4.9 KB) - added by devel@… 7 years ago.
Rearrangement of some parts of general/appearance settings
mythbackend-settings-cleanup-180707.diff (9.2 KB) - added by devel@… 7 years ago.
Cleanup of backend settings in mythtv-setup
mythtv-setup_UserJobs-29092007.diff (6.9 KB) - added by Matthew Wire <devel@…> 7 years ago.
Cleanup of userJobs settings in backendsettings.cpp

Download all attachments as: .zip

Change History (19)

Changed 7 years ago by devel@…

Cleanup of database settings dialog

comment:1 Changed 7 years ago by devel@…

dbsettings-cleanup
This patch cleans up the database settings dialog.

  • Hides database type since there is currently only one suppported in Mythtv.
  • Cleans up wording and layout of first page.
  • Changes wording of second page to be more generic.

Changed 7 years ago by devel@…

Virtual Keyboard, Menu theme descriptions

comment:2 Changed 7 years ago by devel@…

frontend-virtualkeyboard_and_menutheme-description

  • Adds help text for Menu Theme option in Appearance.
  • Improves wording, description and help-text for Virtual keyboard option since this works on more than just line-edit dialogs now.

Changed 7 years ago by devel@…

Rearrangement of some parts of general/appearance settings

comment:3 Changed 7 years ago by devel@…

frontend-generalsettings-cleanup

  • Create triggered configuration group for Network control interface so port setting is only displayed when enabled.
  • Move LogMaxCount? into configurationgroup with the rest of the log settings.
  • Create new "Miscellaneous" page after Audio page. Contains pin code setup and shutdown settings.
  • Rename first "General" page to Control. Move UseVirtualKeyboard? here from appearance, also insert network control settings here.
  • Move QT settings dialog to third position in Appearance and rename QT / Appearance (also remove UseVirtualKeyboard?).

Changed 7 years ago by devel@…

Cleanup of backend settings in mythtv-setup

comment:4 Changed 7 years ago by devel@…

mythbackend-settings-cleanup

  • Creates separate Configurationgroup on the same page for local backend ip/port and master backend ip/port. Makes host setup much clearer.
  • Changes wording of WOL backend wakeup and shutdown settings to make them (hopefully) clearer.
  • Split "backend" page into two pages: "locale" and "file management settings".
  • Rename WakeOnLan? settings to Backend Wakeup Settings and split into two sections for master and slave backends.
  • Rename "Host specific" page to "Backend specific" since most settings refer to backend rather than host.

comment:5 Changed 7 years ago by stuartm

  • Milestone changed from unknown to 0.21
  • Owner changed from ijr to stuartm

comment:6 Changed 7 years ago by stuartm

(In [14112]) Refs #3753

Improves virtual keyboard setting description and adds a missing description for the Menu Theme setting.

Patch by devel@…

comment:7 Changed 7 years ago by stuartm

(In [14114]) Refs #3753

Cleans up the database settings page. Improves wording and help text. Hides the database type setting.

Patch by devel@…, whitespace changes by me.

comment:8 Changed 7 years ago by stuartm

(In [14121]) Mythtv-setup general settings cleanup. See #3753 for more information.

Refs #3753. Patch by devel@…

The patch included the security pin setting from the autodiscovery patch. I've left the setting in there, but disabled it for now until the autodiscovery patch is committed.

comment:9 Changed 7 years ago by stuartm

  • Resolution set to fixed
  • Status changed from new to closed

(In [14122]) Last patch by devel@… to tidy up settings, this time the frontend general and appearance settings.

Closes #3753.

Changed 7 years ago by Matthew Wire <devel@…>

Cleanup of userJobs settings in backendsettings.cpp

comment:10 Changed 7 years ago by Matthew Wire <devel@…>

  • Resolution fixed deleted
  • Status changed from closed to reopened

mythtv-setup_UserJobs-29092007
This patch cleans up userJobs settings in backendsettings.cpp.
Creates three new functions:
userJob(uint job_num)
userJobDesc(uint job_num)
JobAllowUserJob?(uint job_num)

These replace the 12 original functions which hardcode the job number.

In addition, JobAllowUserJob? will now display the description of the job and will disable the checkbox if there is no command specified for that job.

comment:11 Changed 6 years ago by nigel

Matthew, the patch looks good, and applied cleanly, but there is now a usability problem. On a machine with no jobs, mythtv-setup cannot enable them. The page with the tickboxes has those items disabled, so I went two pages over and put job commands in. When entering "1. General" again, the job backend-specific tickboxes are still disabled. It appears that mythtv-setup needs to be exited and started again.

That isn't a huge problem, but I would prefer if the user didn't have such problems when entering their jobs for the first time. Any chance of a re-work so that maybe

  1. the Job Commands page sets/clears an array of 4 globals that JobAllowUserJob(job_num) uses to enable/disable the tickboxes, and
  1. that page appears before the tickbox page?

comment:12 Changed 6 years ago by nigel

  • Owner changed from stuartm to nigel
  • Status changed from new to assigned

comment:13 Changed 6 years ago by nigel

  • Reporter changed from anonymous to devel@…

comment:14 Changed 6 years ago by nigel

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [15252]) Rationalise User Jobs code. Slightly modified version of Matthew Wire's patch.
(has tidier Description string translation, remove unused .arg). Closes #3753

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.