Opened 12 years ago

Closed 12 years ago

#3763 closed defect (fixed)

dvb subtitles does not work in multirec branch

Reported by: anonymous Owned by: Isaac Richards
Priority: major Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

on the multirec branch, dvb subtitles language can be chosen (in the menu) but no subtitles apear.

subtitles do work in trunk.

Attachments (1)

6763.patch (969 bytes) - added by npr1@… 12 years ago.
patch candidate

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by ilja.jetsu@…

I'll copy that. The information from mytharchivehelper:

Input #0, mpegts, from '/video/mythtv/1033_20070723154000.mpg':
  Duration: 00:23:56.3, start: 58089.508944, bitrate: 3813 kb/s
  Stream #0.0[0x201]: Video: mpeg2video, yuv420p, 720x576, 15000 kb/s, 25.00 fps                                                                             (r)
  Stream #0.1[0x294](eng): Audio: mp2, 48000 Hz, stereo, 224 kb/s
  Stream #0.2[0x911](fin): Data: 0x0000
  Stream #0.3[0xc26]: Data: 0x0000
  Stream #0.4[0xc2a]: Data: 0x0000
  Stream #0.5[0xc2b]: Data: 0x0000
  Stream #0.6[0xc2c]: Data: 0x0000
  Stream #0.7[0xc2d]: Data: 0x0000
  Stream #0.8[0x7eb](fin): Subtitle: dvbsub

says that the subtitle stream is there, but nothing appears from that stream. Older recordings(pre-multirec) work well.

ilja dot jetsu at gmail dot com

DVB-C @ Finland

SVN Revision: 14021

Changed 12 years ago by npr1@…

Attachment: 6763.patch added

patch candidate

comment:2 Changed 12 years ago by npr1@…

Attached a patch that works for me (with DVB-T).

Subtitle and teletext streams weren't being recorded even though steps are taken to include them in the modified PMT. I'm only guessing it was intended like in my patch; someone who knows the MPEGStreamData code needs to tell whether there could be side effects.

This should also fix missing DVB subtitles (and teletext) with IPTV in trunk (assuming the issue is still open; I didn't find the ticket) but I can't test it now so will post only here.

comment:3 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [14449]) Fixes #3763. Records data pids in multirec branch, fix is thanks to patch from npr1 at soumi24 in FInland.

Note: See TracTickets for help on using tickets.