Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#3771 closed patch (fixed)

Patch to properly scale preview video and images

Reported by: Bill <cizek@…> Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In the Watch Recordings screen the Preview image and live video don't always scale well. This generally happens if the aspect ratio or the size of the image doesn't match the aspect / size of the theme's preview area. In this case I see a bunch of leftover images as I scroll through the available recordings.

The attached patch fixes this by doing the following:

  • Expand the image to fill the video area (while preserving the aspect ratio)
  • Letterbox or Pillarbox the resulting image to remove the leftover images mentioned above.

This works on both the live video and the still preview image.

Attachments (2)

preview.scale.patch (7.6 KB) - added by Bill <cizek@…> 12 years ago.
031-preview.scale.patch (8.4 KB) - added by Bill <cizek@…> 12 years ago.
Updated patch

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by Bill <cizek@…>

Attachment: preview.scale.patch added

Changed 12 years ago by Bill <cizek@…>

Attachment: 031-preview.scale.patch added

Updated patch

comment:1 Changed 12 years ago by Bill <cizek@…>

After SVN 14822 the display is still flaky when showing 4:3 images on a 16:9 display. The updated patch fixes this.

-Bill

comment:2 Changed 12 years ago by stuartm

Milestone: unknown0.22
Owner: changed from Isaac Richards to stuartm

Thanks for the patch, I've actually got a fix for this issue in my local tree along with some other follow up changes to what was committed in [14823].

I'll close this ticket when they are committed.

comment:3 Changed 12 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [14865]) More preview image scaling tweaks and fixes. This should now correctly scale and position 4:3 images in 16:9 frames as well as 16:9 in 4:3.

Previews will now use a blackhole widget instead of the container area if it is specified. Not only is this more logical from a theme point of view, it also allows additional images and text to be placed in the video container for display with the preview image e.g. A frame around the preview. Anything placed in the video container will not be displayed unless preview images or video are enabled.

See http://miffteevee.co.uk/imagebin/theme_fullscreen59.png for an example.

Some credit should go to Bill cizek@ as he wrote and submitted a patch to do the same thing long before I independantly started working on fixes. His patch was not used because I saw it too late.

Closes #3771

comment:4 Changed 11 years ago by stuartm

Milestone: 0.220.21
Note: See TracTickets for help on using tickets.