Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3797 closed enhancement (fixed)

Gray letterboxing option

Reported by: anonymous Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: gray pillarbars
Cc: Ticket locked: no

Description

I hate watching programs in the wrong aspect ratio or parts cut off in a zoom mode, but I didn't want to damage my RP set with the black pillarboxes currently provided with Aspect Override turned off. Here is a patch that adds a Gray Pillarboxes option to the Aspect Override menu option. It should perform identical to the Off setting, just with the pillarboxes gray instead of black.

Attachments (4)

pillarbars.diff (3.5 KB) - added by Juppers 13 years ago.
pillarbars.2.diff (2.5 KB) - added by Juppers 13 years ago.
3797-v1.patch (6.4 KB) - added by danielk 13 years ago.
Patch to allow setting the color for mythtv's letterboxing.
pillarbars.3.diff (2.5 KB) - added by Juppers 13 years ago.
Updated for latest SVN.

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by Juppers

Attachment: pillarbars.diff added

comment:1 Changed 13 years ago by danielk

Milestone: 0.21unknown
Owner: changed from Isaac Richards to danielk

This is a good idea, but I don't like putting the menu and especially as part of aspect override. I'll look at this after the next release.

Changed 13 years ago by Juppers

Attachment: pillarbars.2.diff added

comment:2 Changed 13 years ago by Juppers

I didn't like it hooked to the aspect override either after I thought about it some more. Now it is a seperate setting under TV Settings, Playback. The menu part you still won't like, but the second patch does require a field in settings named GrayPillars?, 0 for off, 1 for on, so it can be toggled without having to recompile.

I tried to replace the first patch, but was told no. If you could please remove that one for me that would be appreciated.

Changed 13 years ago by danielk

Attachment: 3797-v1.patch added

Patch to allow setting the color for mythtv's letterboxing.

comment:3 Changed 13 years ago by danielk

Summary: Patch to add a gray pillarboxes option to Aspect OverrideGray letterboxing option

I created a new patch based on this concept that allows adding more colour options than just grey. As with Juppers' patch, so far this only works for some X11 based video rendering methods.

Changed 13 years ago by Juppers

Attachment: pillarbars.3.diff added

Updated for latest SVN.

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [14955]) Fixes #3797. Adds color control for letterboxing color used by MythTV, currently the options are gray0 (i.e. black) and gray25. The intent is to allow plasma display owner to even out burn-in by selecting a gray borders rather than the default black ones.

comment:5 Changed 13 years ago by skamithi

(In [15452]) Refs #2287 Refs #3797. add gray letterboxing support for opengl renderer.

Note: See TracTickets for help on using tickets.