Opened 12 years ago

Closed 11 years ago

#3799 closed defect (fixed)

Rename preview images in mythrename.pl

Reported by: sphery <mtdean@…> Owned by: xris
Priority: minor Milestone: 0.21
Component: perl / nuvexport Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch is meant to rename the preview images when recording files are renamed by mythrename.pl. I haven't tested it in place (as I don't rename my recordings--I create links), but have done testing with a little "test harness" (just the rename code and some variable initializations in a separate script).

Notes for committer: As a non-Perl coder, I don't know if there's some way to use the value $show->{'local_path'} in the glob/wildcard (direct placement doesn't work), but copying its value to $old_name definitely works. There may also be a prettier way to grab the dimensions from $current_preview (i.e. a one-liner or something), but the approach in the patch works and handles "empty" values for dimensions (i.e. for the frontend preview image).

Attachments (1)

mythtv-mythrename_previews.patch (1.4 KB) - added by sphery <mtdean@…> 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by sphery <mtdean@…>

comment:1 Changed 12 years ago by xris

Component: contribperl / nuvexport
Owner: changed from Isaac Richards to xris
Status: newassigned

comment:2 Changed 12 years ago by xris

Milestone: unknown0.22

comment:3 Changed 12 years ago by xris

Milestone: 0.220.21

comment:4 Changed 11 years ago by xris

(In [16106]) re #3799 rename preview images when the parent recordings are renamed. Also now trusts mythtv to get have the correct file suffix (since .20 has been out for ages) so stop examining the whole file just to see if we need mpg or nuv suffix -- huge speedup.

comment:5 Changed 11 years ago by xris

Resolution: fixed
Status: assignedclosed

(In [16107]) closes #3799: rename preview images when the parent recordings are renamed. Also now trusts mythtv to get have the correct file suffix (since .20 has been out for ages) so stop examining the whole file just to see if we need mpg or nuv suffix -- huge speedup.

Note: See TracTickets for help on using tickets.