Opened 17 years ago
Closed 17 years ago
#3827 closed defect (invalid)
Fix for compile error
Reported by: | anonymous | Owned by: | Isaac Richards |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | unknown |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Here is what I had to do fix a compile error.
--- mythtv/libs/libavcodec/avcodec.h.orig 2007-08-14 16:41:35.382943338 -0400 +++ mythtv/libs/libavcodec/avcodec.h 2007-08-14 16:41:58.946773194 -0400 @@ -43,7 +43,7 @@ #define LIBAVCODEC_IDENT "Lavc" AV_STRINGIFY(LIBAVCODEC_VERSION) -#define AV_NOPTS_VALUE INT64_C(0x8000000000000000) +#define AV_NOPTS_VALUE INT64_C(0x8000000000000000ULL) #define AV_TIME_BASE 1000000 #define AV_TIME_BASE_Q (AVRational){1, AV_TIME_BASE}
Change History (4)
comment:1 Changed 17 years ago by
comment:2 Changed 17 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
Which compiler and which version are you using? Please post the compiler error message.
the proposed change is wrong if you look how INT64_C is defined in glibc's stdint.h
define INT64_C(c) c ## LL
comment:3 Changed 17 years ago by
Resolution: | invalid |
---|---|
Status: | closed → reopened |
I´m getting this error compiling mythplugins (rev 14290):
./../../include/qt3 -I/usr/X11R6/include -o aacdecoder.o aacdecoder.cpp aacdecoder.cpp: In member function ‘bool aacDecoder::initializeMP4()’: aacdecoder.cpp:305: error: invalid conversion from ‘long unsigned int*’ to ‘uint32_t*’ aacdecoder.cpp:305: error: initializing argument 4 of ‘int8_t NeAACDecInit2(void*, unsigned char*, uint32_t, uint32_t*, uint8_t*)’ make[2]: * [aacdecoder.o] Fehler 1 make[2]: Leaving directory `/usr/local/src/myth-svn/mythplugins/mythmusic/mythmusic' make[1]: * [sub-mythmusic] Fehler 2 make[1]: Leaving directory `/usr/local/src/myth-svn/mythplugins/mythmusic' make: * [sub-mythmusic] Fehler 2
Compiler is:
gcc version 4.1.3 20070629 (prerelease) (Debian 4.1.2-13)
Wouldn't a better fix be to change the INT64_C to UINT64C?
As in:
#define AV_NOPTS_VALUE UINT64_C(0x8000000000000000)