Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3833 closed patch (fixed)

Mythtv should allow linking with -ldca, instead of forced -ldts.

Reported by: Samuli Suominen <drac@…> Owned by: Janne Grunau
Priority: trivial Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

libdts development has stopped, and new name for library is libdca. It's API compatible with libdts, libdca also installs libdts.pc (same as libdca.pc), dts.h (same as dca.h) but does not install libdts, but libdca instead. So trivial fix would be to allow linking also with -ldca.

[1] http://download.videolan.org/pub/videolan/libdca/0.0.5/ [2] http://www.videolan.org/developers/libdca.html

Untested / suggested patch:

--- configure.orig 2007-08-15 19:52:13.000000000 +0300 +++ configure 2007-08-15 19:55:52.000000000 +0300 @@ -2322,7 +2322,9 @@

die "Only one of amr_nb and amr_nb_fixed may be enabled."

if enabled libdts; then

  • if has_library libdts_pic; then

+ if has_library libdca; then + dtslib="-ldca" + elif has_library libdts_pic; then

dtslib="-ldts_pic"

elif has_library libdts; then

dtslib="-ldts"

(janneg said he will look at this issue, but opening this so we can track it more easily.)

Attachments (1)

configure.patch (437 bytes) - added by Samuli Suominen <drac@…> 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by Samuli Suominen <drac@…>

Attachment: configure.patch added

comment:1 Changed 12 years ago by Janne Grunau

Milestone: unknown0.21
Owner: changed from Isaac Richards to Janne Grunau
Version: unknownhead

comment:2 Changed 12 years ago by Janne Grunau

(In [14234]) Refs #3833. use libdca for DTS decoding if no libdts is available

comment:3 Changed 12 years ago by Janne Grunau

(In [14236]) Refs #3833. test for libdca first. gentoo's libdca ebuild creates a libdts.a symlink

comment:4 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: newclosed

(In [14237]) Closes #3833. Add a config variable for the dts library and check for libdca

comment:5 Changed 12 years ago by Janne Grunau

(In [14267]) carry libdts_pic check over from trunk. Refs #3833

comment:6 Changed 12 years ago by R. Geoffrey Newbury <newbury@…>

The error message emitted by configure should also be fixed as it is now misleading. The error message at about line 2330 refers to the 'libdts' library, which clearly may no longer exist. See my attempt to note this in closed ticket 3860. IJR rejected this amendment as distribution specific. It appears that that may not be the case. Upstream (videolan) has changed the name. The error message should refer to both possibilities.

Note: See TracTickets for help on using tickets.