Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3841 closed patch (fixed)

mytharchive fails with caddy DVD writer when running growisofs

Reported by: anonymous Owned by: paulh
Priority: minor Milestone: unknown
Component: mytharchive Version: head
Severity: medium Keywords: mytharchive fail growisofs
Cc: paulh Ticket locked: no

Description

Hi, mythburn.py currently tries to open and close the cdrom drive, if growisofs fails.

My first thought was, that the drive should get in a state where it is not ready, but my drive does not fail anymore, when getting the status of it before running growisofs. It failed for me every time i created a dvd with mytharchive. So i made following changes:

  1. The status of the drive is checked. If the Media is OK or getting status of the drive is not implemented, growisofs starts
  2. If the tray is open it waits until the user closes the tray
  3. If there is no media inserted, it opens the tray
  4. if the drive is not ready it resets it.

Attachments (2)

mythburn.patch (3.6 KB) - added by lukas.kasprowicz@… 12 years ago.
mythburn.2.patch (3.6 KB) - added by lukas.kasprowicz@… 12 years ago.
Please ignore the patch above.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by lukas.kasprowicz@…

Attachment: mythburn.patch added

comment:1 in reply to:  description Changed 12 years ago by anonymous

I forgot to tell why it fails. It is because the caddy DVD writer is not able to close the tray.

Changed 12 years ago by lukas.kasprowicz@…

Attachment: mythburn.2.patch added

Please ignore the patch above.

comment:2 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [14308]) Improved DVD burning in mythburn.py

  • The status of the drive is checked. If the Media is OK or getting status of the drive is not implemented, growisofs starts.
  • If the tray is open it waits until the user closes the tray.
  • If there is no media inserted, it opens the tray.
  • If the drive is not ready it resets it.

I modified the patch slightly to make sure we don't get stuck in an infinite loop waiting for a good status.

Patch by Lukas Kasprowicz. Closes #3841.

comment:3 Changed 12 years ago by danielk

(In [14430]) Refs #3841. Backports [14429] to 0.20-fixes, this refines the handling of the 'new' tag.

comment:4 Changed 12 years ago by danielk

Sorry [14430] should have referenced #3842.

Note: See TracTickets for help on using tickets.