Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3875 closed defect (fixed)

changeset 14292 or earlier breaks mythmusic compile on x86_64 gcc 4.1.1 (FC6)

Reported by: anonymous Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Below from trunk 14294:

aacdecoder.cpp: In member function ‘bool aacDecoder::initializeMP4()’:
aacdecoder.cpp:302: error: cannot convert ‘uint32_t*’ to ‘long unsigned int*’ for argument ‘4’ to ‘char NeAACDecInit2(void*, unsigned char*, long unsigned int, long 
unsigned int*, unsigned char*)’
make[2]: *** [aacdecoder.o] Error 1
make[2]: Leaving directory `/export/data1/mythtv_compile/svn.14294/mythplugins/mythmusic/mythmusic'
make[1]: *** [sub-mythmusic] Error 2
make[1]: Leaving directory `/export/data1/mythtv_compile/svn.14294/mythplugins/mythmusic'
make: *** [sub-mythmusic] Error 2

last compile was with 14223. Presumably related to ticket 3827?

Change History (2)

comment:1 Changed 13 years ago by Janne Grunau

Resolution: fixed
Status: newclosed

(In [14302]) Fixes #3875. reverts [14292]

The official faad.h has unsigned long int in it's function declarations so original code is correct. Some linux Distros (Gentoo, Debian, ...) patch the public API to use stdint.h types. There is some code to handle both gracefully, which might be not in all cases correct.

comment:2 Changed 13 years ago by Janne Grunau

(In [14303]) Refs #3875. Fix totally broken workaround for compatibility if modified faad2 header on LP64

Note: See TracTickets for help on using tickets.