Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#3917 closed patch (fixed)

"Fix" Programinfo::ForgetHistory to let current recordings re-record without deleting first

Reported by: Tony Lill Owned by: cpinkham
Priority: minor Milestone: 0.21
Component: mythtv Version: 0.20-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In the "Prevously Recorded" menu, if you select "Allow this episode to re-record" and the recording is a current recording, nothing happens unless you also delete the recording. By having ForgetHistory? clear the duplicate flag in the recorded table as well as oldrecorded (plus a little fix to scheduler to counting max episodes), "Allow this episode to re-record" works properly.

The attached patch also adds a menu item to "Watch Recordings"->"Recording Options" to invoke this functionality. The patch is against 0.20-fixes, but applies to the head with just a bit of fuzz. I also have an enchancement to mythcommflag to detect broken recordings (to be submitted in a separate ticket) that will use this.

Attachments (2)

rerecord.patch (5.9 KB) - added by ajlill@… 12 years ago.
rerecord.2.patch (7.2 KB) - added by Tony Lill <ajlill@…> 12 years ago.
Missed an instance of episode counting in the auto expire code in last patch

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by ajlill@…

Attachment: rerecord.patch added

Changed 12 years ago by Tony Lill <ajlill@…>

Attachment: rerecord.2.patch added

Missed an instance of episode counting in the auto expire code in last patch

comment:1 Changed 12 years ago by Tony Lill <ajlill@…>

After using this patch for two month, I've found that having an allow re-record button available from the watch recordings screen even more usefull than I originally imagined. I'm sure others will too. Would it be possible to get this ticket set as an enhancement for 0.21? Also, could someone change the "reported by" field to me? Thanks.

comment:2 Changed 12 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham
Reporter: changed from anonymous to Tony Lill
Status: newassigned

comment:3 Changed 12 years ago by cpinkham

Milestone: unknown0.21

comment:4 Changed 12 years ago by cpinkham

Type: defectpatch

comment:5 Changed 12 years ago by cpinkham

Resolution: fixed
Status: assignedclosed

(In [15808]) Add a menu option to allow the user to tell Myth to forget that it recorded a particular recording so that it can be rerecorded even if it is a duplicate.

The 'forgotten' program also no longer counts in the maxepisodes count for the scheduled recording so that it may be rerecorded.

This is useful when you have a bad recording of a program and want to give Myth a chance to record a new copy without having to delete the old one first.

Closes #3917 using patch by Tony Lill.

comment:6 Changed 10 years ago by shane

(In [20387]) Closes #6438 Fixes maxepisodes regression with back-to-back recordings

When there are back-to-back scheduled recordings and maxEpisodes is set and maxNewest is not, maxEpisodes is not respected.

This change removes the duplicate check added to the maxepisodes query in [15808]. The maxexpisodes query will now count all recordings that are not preserved.

Refs #3917

Thanks to David Engel, Chris Pinkham and Sphery.

Note: See TracTickets for help on using tickets.