Opened 12 years ago

Closed 12 years ago

#3937 closed enhancement (fixed)

Mythmusic time display and pause seeking enhancements

Reported by: otto at kolsi dot fi Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

MythMusic player calculates displayed playback time in three places, two of these are wrong. This can be seen e.g. if you simply press STOP while playing -> song time display is incorrect.

First attached patch (mythmusic-time-fix.patch) fixes time display issue and cleans up the code a bit.

Currently while playback is paused, you can only seek one step back or forward, not more. Also the time display and progress bar are not updated. Attached second patch (mythmusic-pause-seek.patch) fixes these and allows full seeking and updates time and progress bar.

With these patches, LCD display is NOT updated while seeking when paused. I also noticed that when you resume playback after pause&seek, there's maybe 0.5s "previous" audio in some buffer that is played before playback is continued from the correct place. It would be nice if someone knows how to fix this so that playback is always resumed cleanly without this "distortion".

Second patch is produced with "diff -u" since I don't know how to create incremential SVN diffs. If someone knows, please advice.

Attachments (2)

mythmusic-time-fix.patch (3.8 KB) - added by otto at kolsi dot fi 12 years ago.
mythmusic-pause-seek.patch (408 bytes) - added by otto at kolsi dot fi 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by otto at kolsi dot fi

Attachment: mythmusic-time-fix.patch added

Changed 12 years ago by otto at kolsi dot fi

Attachment: mythmusic-pause-seek.patch added

comment:1 Changed 12 years ago by paulh

Milestone: unknown0.21
Owner: changed from Isaac Richards to paulh

comment:2 Changed 12 years ago by paulh

(In [14715]) Fix MythMusic's time display and clean up the code a bit. Patch by Otto. Refs #3937.

comment:3 Changed 12 years ago by paulh

Resolution: fixed
Status: newclosed

(In [14716]) Allow seeking in MythMusic while paused.

Patch by Otto. Modified by me so the position on the LCD also updates for those people who like to use MythMusic with the TV switched off.

Closes #3937.

Note: See TracTickets for help on using tickets.