Opened 12 years ago

Closed 12 years ago

#3971 closed patch (wontfix)

Install MythWeather PERL modules into PERL @INC path

Reported by: Joe Ripley <vitaminjoe@…> Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythweather Version: head
Severity: low Keywords: MythWeather, PERL modules
Cc: stuartm Ticket locked: no

Description

This patch moves all of the *.pm PERL modules from the mythplugins/mythweather/mythweather/scripts directory into mythplugins/mythweather/perl/ directory. It includes a Makefile.PL based on the one authored by Chris Petersen for the MythTV.pm module.

It also modifies all of the *.pl files that reference the *.pm files to use the proper module path (i.e. Mythweather::).

Hopefully this will help get the modules into a more appropriate installation location.

  • Joe

Attachments (3)

3971_diff.patch (74.9 KB) - added by Joe Ripley <vitaminjoe@…> 12 years ago.
Move MythWeather? PERL modules to mythplugins/mythweather/perl and include files necessary to install modules to system PERL @INC directories
3971_diff_2.patch (16.2 KB) - added by Joe Ripley <vitaminjoe@…> 12 years ago.
Makes necessary changes to *.pl and *.pm files for the change in module installation location
3971_diff.2.patch (84.7 KB) - added by Joe Ripley <vitaminjoe@…> 12 years ago.
Combines both previous patches in this ticket into one patch

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 3971_diff.patch added

Move MythWeather? PERL modules to mythplugins/mythweather/perl and include files necessary to install modules to system PERL @INC directories

Changed 12 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 3971_diff_2.patch added

Makes necessary changes to *.pl and *.pm files for the change in module installation location

comment:1 Changed 12 years ago by Joe Ripley <vitaminjoe@…>

The second patch updates all of the *.pl and *.pm files in the scripts directory to use the new installation location for the MythWeather? PERL modules.

Please note that these updated *.pm files are the ones that should be moved to the mythplugins/mythweather/perl directory referenced in the first patch (3971_diff.patch).

Hopefully that all makes sense. :)

-- Joe Ripley vitaminjoe@…

Changed 12 years ago by Joe Ripley <vitaminjoe@…>

Attachment: 3971_diff.2.patch added

Combines both previous patches in this ticket into one patch

comment:2 Changed 12 years ago by stuartm

Owner: changed from ldunning to stuartm
Status: newassigned

Anyone want to suggest an alternative to splitting the modules from the rest of the scripts? Do the modules have to be in @INC or even modules? (been a while since I touched perl so my memory is hazy)

As a last resort it's ok, but if possible I'd like to preserve the simplicity of adding new grabbers to mythweather. The idea is that users can just extract a new grabber to the scripts directory on the system and it's instantly available to mythweather without the need for a new install or upgrade. If files have to be installed in different places then it starts to get complicated.

In the future I hope to have mythweather download new scripts and updates automatically from the mythtv.org website. If we have to install modules to @INC that's going to be pretty difficult since in most cases users won't have permission to write to those paths.

comment:3 Changed 12 years ago by stuartm

Resolution: wontfix
Status: assignedclosed

After discussing this on IRC, I'm going to leave things the way they are. I added a use lib trick a while back so that the modules didn't need to be in @INC. If there are any places I missed then let me know.

Note: See TracTickets for help on using tickets.