Opened 12 years ago

Closed 12 years ago

#4009 closed patch (fixed)

Add 14:9 aspect ratio override

Reported by: danielk Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Oscar Carlsson reported a problem where a broadcaster is using the 14:9 compromise aspect ratio instead of 4:3 or 16:9 for a PAL sized frame. The attached patch adds this compromise aspect ratio to the aspect ratio overrides.

This patch could be a somewhat tidier, but it works..

Attachments (1)

4009-v1.patch (4.7 KB) - added by danielk 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by danielk

Attachment: 4009-v1.patch added

comment:1 Changed 12 years ago by Oscar Carlsson

When playing back a DVD with the internal player, it selected 14:9 instead of 16:9, using this patch.

comment:2 Changed 12 years ago by danielk

Oscar, you set 14:9 as an override, correct? Since the override is not on a per-input basis this is normal; you are telling MythTV to ignore the aspect ratio set in the stream and use a specific aspect ratio. This override really should be set on a per-recording-rule basis. But a global override is all that has been implemented and reimplementing aspect overrides to be a recording attribute would require a non-trivial amount of work.

-- Daniel

comment:3 Changed 12 years ago by danielk

(In [14592]) Refs #4009. Places videoout helper enums and typedefs that are used throughout MythTV in their own file videoouttypes.h.

This changeset looks bigger than it is, because this uses enums throughtout where the enums had been cast to int before.

When looking at the #4009, aspect ratio issue the other day I noticed that the translation strings for these are created in multiple places because it is not safe to include videooutbase.h everywhere. And we are also passing these around as integers and hard defining the MAX value of the enums throughout the code. The reduntant translations are error prone and the use of hard coded MAX values is dangerous when new items are added or removed from an enum.

The new videoouttypes.h has been added to the translate.pro and some strings that should have been translated before but were in files that aren't in translate.pro will now be availabe for translation.

comment:4 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [14593]) Fixes #4009. Adds 14:9 aspect ratio to overrides.

This is a compromize aspect ratio used by some broadcasters when broadcasting 16:9 material over PAL/NTSC, it makes the black bars at the top and bottom slightly smaller without looking terrible to most viewers. By telling MythTV the actual aspect ratio is 14:9 and not 4:3 you can zoom into this type of video and see it with the correct aspect ratio and without any letterboxing on a 16:9 display.

Note: See TracTickets for help on using tickets.