Opened 14 years ago

Closed 14 years ago

#4027 closed defect (invalid)

MythMusic audio device shouldn't be translatable

Reported by: anonymous Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no



I've seen reports from users where MythMusic wouldn't output any audio while regular playback works fine. This usually happens because a translator changed "default" in the MusicAudioDevice? combobox to its localized counterpart.

IMHO, this can easily be remedied by making that string not translate anymore. The offending line is in mythmusic/globalsettings.cpp at line 45:

gc->addSelection(QObject::tr("default"), "default");

Maybe someone who knows more about Qt (and how it handles translatable strings) than me could fix that :)

Change History (1)

comment:1 in reply to:  description Changed 14 years ago by paulh

Resolution: invalid
Status: newclosed
Version: unknownhead

Your assumption is wrong. The first parameter to addSelection() is the string that will be displayed to the user so there is no problem with that being translated. It is the second parameter, "default" in this case, that is the value that is stored in the DB settings table.

Just to be sure I switch to French and set that setting to 'Défaut' and MythMusic was still working.

Note: See TracTickets for help on using tickets.