Opened 14 years ago

Closed 14 years ago

#403 closed patch (fixed)

init.php: image_cache directory creation too clever by half

Reported by: Adam Di Carlo <aph@…> Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version:
Severity: low Keywords:
Cc: Ticket locked: no

Description

The image_cache directory handling is pretty broken. For one thing, it will strip off a leading slash.

Rather than split on path components and try to mkdir every directory, I think it's better to just check and/or create the exact image_cache directory, and exit if the mkdir fails. This simplifies the code.

Attachments (1)

2005-09-30_init_image_cache.diff (802 bytes) - added by Adam Di Carlo <aph@…> 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by Adam Di Carlo <aph@…>

comment:1 Changed 14 years ago by Adam Di Carlo <aph@…>

Summary: init.php: image_cache directory creation is brokeninit.php: image_cache directory creation too clever by half
Type: defectpatch

The attachment is against the 0.18 branch.

comment:2 Changed 14 years ago by Adam Di Carlo <aph@…>

Component: mythtvmythweb
Owner: changed from Isaac Richards to xris

comment:3 Changed 14 years ago by xris

Resolution: fixed
Status: newclosed

Basically applied your patch, but it's also a moot point as svn now lets me more easily manage actually including this directory in the repository.

Note: See TracTickets for help on using tickets.