Opened 15 years ago
Closed 15 years ago
#403 closed patch (fixed)
init.php: image_cache directory creation too clever by half
| Reported by: | Owned by: | xris | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythweb | Version: | |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The image_cache directory handling is pretty broken. For one thing, it will strip off a leading slash.
Rather than split on path components and try to mkdir every directory, I think it's better to just check and/or create the exact image_cache directory, and exit if the mkdir fails. This simplifies the code.
Attachments (1)
Change History (4)
Changed 15 years ago by
| Attachment: | 2005-09-30_init_image_cache.diff added |
|---|
comment:1 Changed 15 years ago by
| Summary: | init.php: image_cache directory creation is broken → init.php: image_cache directory creation too clever by half |
|---|---|
| Type: | defect → patch |
comment:2 Changed 15 years ago by
| Component: | mythtv → mythweb |
|---|---|
| Owner: | changed from Isaac Richards to xris |
comment:3 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Basically applied your patch, but it's also a moot point as svn now lets me more easily manage actually including this directory in the repository.
Note: See
TracTickets for help on using
tickets.
The attachment is against the 0.18 branch.