Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4047 closed defect (invalid)

channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels();

Reported by: anonymous Owned by: danielk
Priority: minor Milestone: unknown
Component: perl / nuvexport Version: 0.20.2
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In line 94 of channel_icons.pl $Myth->load_channels(); is used. This creates an error message: Can't locate object method "load_channels" via package "MythTV" at channel_icons.pl line 94.

In none of the perl libraries/programs which comes with mythtv load_channels is used. The function which is available in Myth.pm is called _load_channels. If _load_channels is renamed to load_channels it's working but might break other code.

Please decide which name is correct.

Change History (2)

comment:1 Changed 12 years ago by xris

Resolution: invalid
Status: newclosed

Please don't mix/match MythTV versions. Things are expected to break when you do that.

P.S. underscore prefix is a common way to denote private/protected object methods (which perl has no other way to identify). That method was not intended for public use, and thus it started with an underscore. When I wrote the channel icon script in trunk, and realized that I needed a public method to load channels, the method got renamed. Thus, both are correct. You're using the wrong version of MythTV, and nothing outside of the perl bindings should have ever been using the underscore version of the method name.

comment:2 Changed 12 years ago by xris

Component: channelscanperl / nuvexport
Note: See TracTickets for help on using tickets.