Opened 12 years ago

Closed 12 years ago

#4165 closed defect (fixed)

patches to be able to build mythtv/mythplugins with gcc-4.3

Reported by: ro@… Owned by: Janne Grunau
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

my current patchkit for gcc-4.3, mostly adding missing includes

Attachments (2)

mythtv-gcc43.dif (12.7 KB) - added by ro@… 12 years ago.
patch collection for mythtv
mythplugins-gcc43.dif (6.4 KB) - added by ro@… 12 years ago.
mythplugins gcc-4.3 patch

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by ro@…

Attachment: mythtv-gcc43.dif added

patch collection for mythtv

Changed 12 years ago by ro@…

Attachment: mythplugins-gcc43.dif added

mythplugins gcc-4.3 patch

comment:1 Changed 12 years ago by Janne Grunau

Milestone: unknown0.21
Owner: changed from Isaac Richards to Janne Grunau
Status: newassigned
Version: unknownhead

comment:2 Changed 12 years ago by Janne Grunau

(In [14852]) Refs #4165. remove unneeded ifdef, ARCH_X86 is defined on ARCH_X86_64 since ffmpeg merge in [13655]

comment:3 Changed 12 years ago by Janne Grunau

(In [14853]) Refs #4165. fix argument names in BlendToYV12 function declaration

comment:4 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: assignedclosed

(In [14854]) Closes #4165. Add missing includes for gcc-4.3 compilation. mostly cstdlib/stdlib.h

comment:5 Changed 12 years ago by Janne Grunau

I haven't applied the configure change (s/-mcpu=/-mtune=/) and the change to libs/libmythupnp/upnputil.h.

I would like to handle the first differently.

And the second looks like adding a workaround to a workaround. Can you please test whether including <sys/types.h> in upnputil.h and changing suseconds_t to suseconds_t fixes compilation too?

comment:6 Changed 12 years ago by ro@…

thanks for taking this up so quickly.

yes, I'll try including <sys/types.h> in upnputil.h.

comment:7 Changed 12 years ago by ro@…

Resolution: fixed
Status: closednew

just found two new ones and one older one not reported yet:

the old one: libs/libmyth/mythconfiggroups.cpp needs to include <algorithm> for "find"

the two recent ones: mythplugins/mythmusic/mythmusic/main.cpp needs to include stdlib.h for "getenv"

mythtv/libs/libmythtv/filtermanager.cpp needs to include stdlib.h for "free"

and yes, including <sys/types.h> in upnputil.h does definitely work.

comment:8 Changed 12 years ago by Janne Grunau

(In [15133]) Refs #4165. use proper POSIX suseconds_t instead of of the private suseconds_t

comment:9 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: newclosed

(In [15134]) Closes #4165. adding missing includes for gcc-4.3

Note: See TracTickets for help on using tickets.