Opened 12 years ago

Closed 12 years ago

#4169 closed patch (fixed)

MythWeather BBC script and rain icons

Reported by: otto at kolsi dot fi Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythweather Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached patch modifies BBC weather scripts and changes/adds icons for following weather conditions:

  • light snow
  • heavy snow
  • sleet

Currently e.g. thunder showers icon is shown for both types of snow conditions which is not right.

Attachments (2)

mythweather-rainicons.patch (1.8 KB) - added by otto at kolsi dot fi 12 years ago.
bbc-grabber.patch (3.2 KB) - added by otto at kolsi dot fi 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by otto at kolsi dot fi

Attachment: mythweather-rainicons.patch added

comment:1 Changed 12 years ago by stuartm

Milestone: unknown0.21
Owner: changed from ldunning to stuartm
Status: newassigned

comment:2 Changed 12 years ago by stuartm

Resolution: fixed
Status: assignedclosed

(In [14861]) Add a new 'sleet' condition to the BBC scripts and make the existing snow conditions use the proper images.

Patch by okolsi

Closes #4169

comment:3 Changed 12 years ago by otto at kolsi dot fi

Resolution: fixed
Status: closedreopened

My earlier patch had couple of mistakes (copy & paste etc.) in both BBC current and threeday scripts. I'll attach a new patch that:

  • fixes 'heavy snow' in both scripts
  • fixes 'light snow' and 'sleet' in three day script
  • adds 'misty', 'partly cloudy', 'light snow showers' and 'clear' to both scripts

I haven't created any new images but tried to add these to closest existing image.

Changed 12 years ago by otto at kolsi dot fi

Attachment: bbc-grabber.patch added

comment:4 Changed 12 years ago by stuartm

(In [15040]) Fixes some icon mapping and creates new mappings for 'misty', 'partly cloudy', 'light snow showers' and 'clear' in the BBC weather grabber.

Patch by Otto Kolsi.

Closes #4169

(Commit hook failed and I'm unable to close this manually because trac is broken)

comment:5 Changed 12 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

Fixed in [15040].

Note: See TracTickets for help on using tickets.