Opened 12 years ago

Closed 11 years ago

#4177 closed defect (fixed)

Streaming in mythweb doesn't work for files with special characters

Reported by: anonymous Owned by: xris
Priority: minor Milestone: 0.21
Component: mythweb Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I use contrib/mythrename.pl to rename recordings, this breaks streaming in mythweb if the resultant filename has spaces or other special characters. This is because the invocation of ffmpeg is a simple call to open() which invokes ffmpeg in a shell. Using the 'list form' of open fixes this by invoking ffmpeg direct.

The attached 1-line patch fixes this. This will not affect streaming for people not using mythrename.pl.

Note: my perl (v5.8.8) claims that this list form of perl isn't supported on all platforms, but is supported on all platforms supporting fork and that if you're running a Unix variant you'll be OK. I've only tested this on Linux.

Attachments (1)

stream-handler-open.patch (749 bytes) - added by mythtv-dev.spam@… 12 years ago.
patch to make handler.pl use list form of open to invoke ffmpeg

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by mythtv-dev.spam@…

Attachment: stream-handler-open.patch added

patch to make handler.pl use list form of open to invoke ffmpeg

comment:1 Changed 12 years ago by xris

Milestone: 0.21

comment:2 Changed 11 years ago by Rob Smith

Status: newinfoneeded_new

What happens if we quote the filename, will that work? (escaping the quote char of course...)

comment:3 Changed 11 years ago by xris

Resolution: fixed
Status: infoneeded_newclosed

(In [16064]) open ffmpeg with list mode instead of string mode, should fix handling of international characters in filenames and close #4177

comment:4 Changed 11 years ago by xris

(In [16065]) open ffmpeg with list mode instead of string mode, should fix handling of international characters in filenames and close #4177

comment:5 Changed 11 years ago by xris

Resolution: fixed
Status: closednew

This commit doesn't work because of the unrecognized shell filehandle redirect.

comment:6 Changed 11 years ago by xris

(In [16108]) re #4177, rethink this fix and use shell escaping so we can properly redirect stderr into nothingness.

comment:7 Changed 11 years ago by xris

Resolution: fixed
Status: newclosed

(In [16109]) r16108 from trunk to close #4177: rethink this fix and use shell escaping so we can properly redirect stderr into nothingness.

Note: See TracTickets for help on using tickets.