Opened 14 years ago

Closed 14 years ago

#420 closed patch (fixed)

UK DVB EIT enhancements

Reported by: John Pullan <john.pullan@…> Owned by: danielk
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: low Keywords: DVB EIT
Cc: Ticket locked: no

Description

More updates to the UK EIT parsing code

The attached patch does the following :

Strips out "...." to join Title - Subtitles up Enables the use of "?" or "!" as a subtitle limiter Removes a hack I'd put in for trying to work out if a subtitle was valid. (now uses a percentage ratio to check if a subtitle is too long) Also fixes a typo in a comment Also changes "Movies" to "Movie" in the category table

Attachments (5)

uk.eit.patch (6.5 KB) - added by John Pullan <john.pullan@…> 14 years ago.
uk.eit.2.patch (6.5 KB) - added by John Pullan <john.pullan@…> 14 years ago.
uk.eit.3.patch (6.4 KB) - added by john.pullan@… 14 years ago.
Update to the patch
uk.eit-no-t4.over-eit-3-patch.diff (682 bytes) - added by Stuart Auchterlonie 14 years ago.
Strips leading T4: from titles. Applies over uk.eit.3.patch
uk.eit-no-t4.over-eit-3-patch.2.diff (681 bytes) - added by Stuart Auchterlonie 14 years ago.
fixup patch to remove T4 from front of program names

Download all attachments as: .zip

Change History (11)

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: uk.eit.patch added

comment:1 Changed 14 years ago by John Pullan <john.pullan@…>

Type: defectpatch

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: uk.eit.2.patch added

comment:2 Changed 14 years ago by John Pullan <john.pullan@…>

please use uk.eit.2.patch instead (found a minor problem)

Changed 14 years ago by john.pullan@…

Attachment: uk.eit.3.patch added

Update to the patch

comment:3 Changed 14 years ago by Stuart Auchterlonie

Having tested this, the percentage based approach to trying to work out where the subtitles begin and end doesn't work very well. Quite a lot of shows have a short title and a long subtitle. Friends is a prime example. With your patch episodes of friends lose there subtitle in the guide data.

Additionally I added support for dropping T4: from the front of channel 4's shows. I'll attach that patch. Applies on top of uk.eit.3.patch.

Changed 14 years ago by Stuart Auchterlonie

Strips leading T4: from titles. Applies over uk.eit.3.patch

Changed 14 years ago by Stuart Auchterlonie

fixup patch to remove T4 from front of program names

comment:4 Changed 14 years ago by Stuart Auchterlonie

Ignore what I said before. My bad. I broke it. I fixed it :-(

But at least now my patch works properly...

comment:5 Changed 14 years ago by danielk

Milestone: 0.19
Owner: changed from Isaac Richards to danielk
Severity: mediumlow
Status: newassigned

I'll look at this today or next week.

comment:6 Changed 14 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [7478]) Closes #420 by applying patch. UK DVB EIT listings fix-ups.

Note: See TracTickets for help on using tickets.