Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#4207 closed defect (fixed)

MythTV.pm doesn't check return code of read.

Reported by: andrew@… Owned by: xris
Priority: minor Milestone: unknown
Component: perl / nuvexport Version: 0.20.2
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When the data is read from the backend there is no checking of the return code for the read.

This can lead to $length being the empty string which then causes Perl to throw an error when it tries to do integer($length).

The attached patch protects from this. I haven't seen the problem personally (it was reported to me) so I haven't been able to fully check it (but the reporter is no longer seeing errors).

Attachments (1)

MythTV.pm.patch​ (670 bytes) - added by andrew@… 16 years ago.
Patch for MythTV.pm

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by andrew@…

Attachment: MythTV.pm.patch​ added

Patch for MythTV.pm

comment:1 Changed 16 years ago by xris

Resolution: → fixed
Status: new → closed

(In [15001]) Convert patch to apply to new IO::INET library. Avoids perl errors when the backend is unreachable. Closes #4207

comment:2 Changed 16 years ago by anonymous

Is there any chance of getting this applied 0.20-fixes as well?

Thanks!

comment:3 Changed 16 years ago by xris

(In [15016]) remove a weird stray character that got added in [15001] (re #4207)

Note: See TracTickets for help on using tickets.