Opened 14 years ago

Closed 14 years ago

#424 closed patch (fixed)

Proper fix for #415 (empty PMT's cause ProgramMapTable::toString() to SEGV)

Reported by: Stuart Auchterlonie Owned by: danielk
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords: pmt signalmonitor
Cc: Ticket locked: no

Description

I've redone the second part of the patch from #415 which wasn't put into [7384].

It also makes sure that the dtvsignalmonitor see's a PMT as valid when there are no audio or video streams if that is what we actually want. This stops the backend from doing a tight loop looking for a valid PMT.

Plus, along the same lines as [7393] the program number of the input PMT is propagated to the output PMT, rather than using a ficticious program number of 1.

Attachments (1)

pmt-tostring-fix.diff (2.4 KB) - added by Stuart Auchterlonie 14 years ago.
Patch to fix problems as described.

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by Stuart Auchterlonie

Attachment: pmt-tostring-fix.diff added

Patch to fix problems as described.

comment:1 Changed 14 years ago by anonymous

I tried this in the hope the last part would fix my multiple PMT per channel issue, but it didn't make any difference. Wasn't getting a segfault, so can't comment on that.

comment:2 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7398]) Closes #424 by applying patch.

I did not add the program number change, this would require also using this program number in the PAT. And there is no need for recordings to use the same program number.

I also added SetAudioStreamsRequired?()/GetAudioStreamsRequired?() to support DVB radio. This defaults to zero, but for DVB radio you would want it to be at least one.

And I also changed the "delete sd;" in TVRec for DVB with sd->deleteLater() for signal/slot safety.

Note: See TracTickets for help on using tickets.