Opened 12 years ago

Closed 11 years ago

#4252 closed enhancement (fixed)

Added hebrew support

Reported by: sagiz@… Owned by: Nigel
Priority: minor Milestone: unknown
Component: translation Version: 0.20-fixes
Severity: medium Keywords: hebrew transalation
Cc: Ticket locked: no

Description

Hi,

I added hebrew support, which required also some very little source changes, and adding an external library (libfribidi).

The patch file is attached.

Currently I changed the 'settings.pro' file to add the libfribidi requirement, because I don't know how to add it in the 'configure'.

Translation status:

  • Most of the usage interface is in 'hebrew' when the hebrew language is selected, but on the other hand most of the settings are still in english.
  • virtual keyboard support.
  • FindProgram? support (needed code change).
  • OSD support (needed code change).
  • Category colors for the guide.

Attachments (1)

hebrew_patch.gz (58.6 KB) - added by sagiz@… 12 years ago.
hebrew translation, with libfribidi dependency, no 'qm' file

Download all attachments as: .zip

Change History (13)

Changed 12 years ago by sagiz@…

Attachment: hebrew_patch.gz added

hebrew translation, with libfribidi dependency, no 'qm' file

comment:1 Changed 12 years ago by ido

kudos on the translation ! seams like a lot of work. Hebrew virtual keyboard, langsettings and FindProgram? are already in the code. maybe we should all coordinate our efforts to prevent duplicate work. OSD display was also patched before, but maybe your solution is better (i just had a quick peek). I was also tempted to change m_justification, but 0 means auto align, which is better.

comment:2 in reply to:  1 ; Changed 12 years ago by sagi

Replying to ido:

kudos on the translation ! seams like a lot of work. Hebrew virtual keyboard, langsettings and FindProgram? are already in the code. maybe we should all coordinate our efforts to prevent duplicate work. OSD display was also patched before, but maybe your solution is better (i just had a quick peek). I was also tempted to change m_justification, but 0 means auto align, which is better.

Thanks :-)

Nice to know there are other Hebrew users out there.

I am using the stable version and didn't find Hebrew support there. Should have looked at the latest sources, but the most important thing for me is stability, so I missed it.

About the m_justification - it is a simple solution and works okay for both RTL and LTR languages (I really didn't have time to look for a better RTL solution, but I'll be happy to get one in the next stable release).

BTW, I also written an EPG grabber in Java, which currently supports only YES (from their site), but can be expanded to support HOT as well; it knows, in addition to titles and start/stop times, to set categories for shows, set episode number/name (which is very important to automate recordings), add actor names and movie air-date. It also uses a file cache to reduce network traffic. I personally didn't find a better YES EPG grabber for Linux, and if there public demand then I can make it a little more user friendly and publish it.

I'm currently quite satisfied with the usability level of my mythtv, but I'll be happy to join forces (especially working on the 'mythfrontend_he.ts' is a tedious task, and I would be happy to see more Hebrew there).

comment:3 in reply to:  2 ; Changed 12 years ago by ido <ido_roseman@…>

Replying to sagi:

yep, there are a few users in Israel :-) i know of at least 1 (who wrote the original OSD patch), and I've seen some more on Linux forum at tapuz. I've open a discussion board on http://communa.tapuz.co.il/mythtv so we can all exchange ideas.

I like the fact you changed TTFFont, as the current solution (see also Ticket #4191) have a problem with multi-line text (the program description).

you can see Changeset 14306 for other things I've done (there's support for the table text with right alignment ).

as for EPG (and I'm writing it so people may google it in the future) : there is of course tv_grab_il from XMLTV. for YES I know it's ok, for HOT it's almost ok (I've submitted a patch). there are several Windows solutions which I understand run under wine (including oddly enough, one that is written in java). I've written a utility in C#, which works great under MONO, I'll be happy to share source and know-how.

comment:4 in reply to:  3 ; Changed 12 years ago by sagi

Replying to ido <ido_roseman@yahoo.com>:

Replying to sagi:

yep, there are a few users in Israel :-) i know of at least 1 (who wrote the original OSD patch), and I've seen some more on Linux forum at tapuz. I've open a discussion board on http://communa.tapuz.co.il/mythtv so we can all exchange ideas.

I like the fact you changed TTFFont, as the current solution (see also Ticket #4191) have a problem with multi-line text (the program description).

Thanks (BTW the description in my EPG is a single line, so I'm not sure my fix solves this).

you can see Changeset 14306 for other things I've done (there's support for the table text with right alignment ).

I'll be happy to get it in the next stable release.

as for EPG (and I'm writing it so people may google it in the future) : there is of course tv_grab_il from XMLTV. for YES I know it's ok, for HOT it's almost ok (I've submitted a patch). there are several Windows solutions which I understand run under wine (including oddly enough, one that is written in java). I've written a utility in C#, which works great under MONO, I'll be happy to share source and know-how.

  • tv_grab_il was broken for a lot of time.
  • WINE solutions are not really Linux solutions. They often break, or don't give you what you need, and you can't fix the source on Linux (and I'm using only Linux).
  • If everything is so great for EPG grabbing on Linux for Israel then why did you write a C# utility ;-)?

comment:5 in reply to:  4 ; Changed 12 years ago by anonymous

Replying to sagi: I'll have to check it on my test system, but in theory multi-line should work, as the rendering of of each reversed line by TTFFont is done after line spliting. you can see current situation on http://img2.tapuz.co.il/communafiles/25131636.jpg notice text is going from bottom to top... I can explain in more details if needed.

again, I assume (and correct me if i'm wrong) you changed m_justification for the text is tables. if so, my solution is more complete (there was a missing calculation). see http://www.tapuz.co.il/Communa/ViewmsgCommuna.asp?Communaid=30171&msgid=25131527 for the result

as for grabbers (and i fill we're Off Topic-ing here) : tv_grab_il broken ? what do you mean ? the version from sorceforge worked fine for me (except for some minor issues i patched). the main problem was with the walla site it is using that had data missing for days long. i started changing it, but my perl skills suck. WINE is not the way to go. i agree ! so i ended up writing with what I know, and I wanted to try MONO... which turned out great. original development was under VS, but i'm planing to port it to monodevelop. I ended up with something not so bad plus some nice features like detailed program description. how do you find episode number/name ?

comment:6 in reply to:  5 Changed 12 years ago by sagi

Replying to anonymous:

Replying to sagi: I'll have to check it on my test system, but in theory multi-line should work, as the rendering of of each reversed line by TTFFont is done after line spliting. you can see current situation on http://img2.tapuz.co.il/communafiles/25131636.jpg notice text is going from bottom to top... I can explain in more details if needed.

again, I assume (and correct me if i'm wrong) you changed m_justification for the text is tables. if so, my solution is more complete (there was a missing calculation). see http://www.tapuz.co.il/Communa/ViewmsgCommuna.asp?Communaid=30171&msgid=25131527 for the result

as for grabbers (and i fill we're Off Topic-ing here) : tv_grab_il broken ? what do you mean ? the version from sorceforge worked fine for me (except for some minor issues i patched). the main problem was with the walla site it is using that had data missing for days long. i started changing it, but my perl skills suck. WINE is not the way to go. i agree ! so i ended up writing with what I know, and I wanted to try MONO... which turned out great. original development was under VS, but i'm planing to port it to monodevelop. I ended up with something not so bad plus some nice features like detailed program description. how do you find episode number/name ?

Your fix indeed looks like the better one. About the episodes - from the screenshots it seems like you're already getting episodes, but to answer your question - I'm parsing the title and splitting it to title and episode (the delimiter is usually the regular expression "[:-]").

comment:7 Changed 12 years ago by Nigel

(In [15694]) Hebrew translation updates from sagiz at yahoo dor com. See #4252. Note that two of the themes/classic/* were not patched due to bad encodings in the patch file

comment:7 Changed 12 years ago by Nigel

Owner: changed from Oscar Carlsson to Nigel
Status: newaccepted

comment:9 Changed 12 years ago by Nigel

(In [15695]) Added Hebrew translation files. See #4252

comment:10 Changed 11 years ago by Nigel

(In [16260]) Correct font for Hebrew popup keyboard. [15694] overwrote the original checked-in version, [14306]. See #4252.

comment:11 Changed 11 years ago by Nigel

(In [16261]) Correct font for Hebrew popup keyboard. [15694] overwrote the original checked-in version, [14306]. See #4252.

comment:12 Changed 11 years ago by Nigel

Resolution: fixed
Status: acceptedclosed

This should now be safely in 0.21 and SVN head.

Note: See TracTickets for help on using tickets.