Opened 12 years ago

Closed 12 years ago

#4272 closed patch (fixed)

Bug fixes

Reported by: andrei@… Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

RingBuffer?.cpp: open() without specifying O_BINARY actually produces some unexpected results on some platforms

tv_play.cpp: potential null pointer

tv_rec.cpp: only include hdrchannel.h if USING_HDHOMERUN

mythplugin.cpp: '+ dlerror()' is appended to the string as char

mythcontext.cpp: d->eventSock has just been allocated, it's the d->serverSock that we are not sure about if connectServer failed

mythmedia.cpp: potential buffer overrun

Attachments (1)

bugs.patch (3.8 KB) - added by andrei@… 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by andrei@…

Attachment: bugs.patch added

comment:1 Changed 12 years ago by danielk

Owner: changed from Isaac Richards to danielk
Priority: majorminor
Severity: highlow

comment:2 Changed 12 years ago by danielk

(In [15061]) Refs #4272. Add O_BINARY open on MS Windows systems, does nothing on most operating systems which don't have an O_BINARY flag.

comment:3 Changed 12 years ago by danielk

(In [15062]) Refs #4272. Fixes possible buffer overflow when using readlink().

comment:4 Changed 12 years ago by danielk

(In [15064]) Refs #4272. Removes compile dependency on hdhomerun.h when HDHomeRun support is disabled.

NOTE: The HDHomeRun library has been tested on Linux and OSX systems under MythTV, and it should also compile on MS Windows, but we try to avoid extranous dependencies in the header files and this is no exception.

comment:5 Changed 12 years ago by danielk

(In [15065]) Refs #4272. Adds a needed NULL pointer check.

comment:6 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [15066]) Fixes #4272. Changes 'system()' call to a 'myth_system()' call, this better isolates the code to port the system() call to non-UNIX operating systems.

Note: See TracTickets for help on using tickets.