Opened 11 years ago

Closed 11 years ago

#4327 closed enhancement (fixed)

[PATCH] Re-write of the eit code for uk DVB

Reported by: john { at } pullan {dot} org Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.21
Component: eit Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

First off, this code incorporates the #3980 fix. Secondly it also attempts to gain more subtitle knowledge from the description. (Takes the first six words up to a period or question mark). Thirdly it fixes some less than tidy code where "..." was being stuck together. Fourthly it adds another series detection mode. Fifthly it fixes a bug in the code where "CSI:" was not being correctly parsed, i.e "CSI:Crime Scene Investigation" was being split into program.title=CSI program.subtitle=Crime Scene Investigation.

Attachments (18)

eitfixup.patch (17.4 KB) - added by anonymous 11 years ago.
eitfixup1.patch (17.6 KB) - added by John {at} Pullan {dot} org 11 years ago.
Up date of patch
eitfixup2.patch (17.9 KB) - added by john {at} pullan {dot} org 11 years ago.
Update of the patch
eitfixup3.patch (2.6 KB) - added by John {at} pullan {dot} org 11 years ago.
eitfixup4.patch (3.0 KB) - added by John {at} pullan {dot} org 11 years ago.
Yet another update.
eitfixup5.patch (3.2 KB) - added by John {at} Pullan {dot} {org} 11 years ago.
Yet another update
eitfixup6.patch (3.5 KB) - added by john {at} pullan {dot} org 11 years ago.
Another minor update
eitfixup7.patch (3.9 KB) - added by John {at} Pullan {dot} org 11 years ago.
eitfixup8.patch (8.3 KB) - added by John {at} Pullan {dot} org 11 years ago.
Further updates
eitfixup9.patch (8.5 KB) - added by John {at} Pullan {dot} org 11 years ago.
Update of file
eitfixup10.patch (4.8 KB) - added by John {at} Pullan {dot} org 11 years ago.
update of patch
eitfixup11.patch (4.9 KB) - added by John {at} Pullan {dot} org 11 years ago.
update of patch
eitfixup12.patch (17.2 KB) - added by john {at} pullan {dot} org 11 years ago.
Experimental fix for the EIT
eitfixup13.patch (17.3 KB) - added by john {at} pullan {dot} org 11 years ago.
eitfixup14.patch (20.8 KB) - added by john {at} pullan {dot} org 11 years ago.
eitfixup15.patch (21.0 KB) - added by john {at} pullan {dot} org 11 years ago.
eitfixup16.patch (23.7 KB) - added by john {at} pullan {dot} org 11 years ago.
Various fixes
eitfixup17.patch (23.5 KB) - added by john {at} pullan {dot} org 11 years ago.

Download all attachments as: .zip

Change History (39)

Changed 11 years ago by anonymous

Attachment: eitfixup.patch added

comment:1 Changed 11 years ago by Stuart Auchterlonie

Milestone: unknown0.21
Owner: changed from Isaac Richards to Stuart Auchterlonie
Status: newassigned

Changed 11 years ago by John {at} Pullan {dot} org

Attachment: eitfixup1.patch added

Up date of patch

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup2.patch added

Update of the patch

comment:2 Changed 11 years ago by Stuart Auchterlonie

(In [15186]) Refs #4327. A small additional change john added in his updated patch which wasn't part of the original checkin.

comment:3 Changed 11 years ago by Stuart Auchterlonie

This didn't get linked to the ticket when I originally submitted it.

(In [15178]). Closes #4327. Refs #3980. UK EIT fixup by john {at} pullan {dot} org

Does a bunch of cleanups to the EIT fixups for the UK, which make it more correct and fix a few niggly issues that people have noticed.

Now handles CSI properly as well as some cases where the ... joining code was incorrectly propagating the whole title/subtitle/desc into the title.

Only one small change from the original patch, which makes sure the airdate being used as a title/description delimiter still works.

comment:4 Changed 11 years ago by Stuart Auchterlonie

(In [15212]) Refs #4327. More improvements to the UK EIT fixup. Improves the results, so things are better than before.

comment:5 Changed 11 years ago by Stuart Auchterlonie

(In [15215]) Refs #4327. Updates to the UK EIT fixup. Makes the use of the original airdate as the delimiter between title & description work again.

comment:6 Changed 11 years ago by John {at} pullan {dot} org

Added another update to help prevent the munging of times across subtitles and descriptions.

Changed 11 years ago by John {at} pullan {dot} org

Attachment: eitfixup3.patch added

Changed 11 years ago by John {at} pullan {dot} org

Attachment: eitfixup4.patch added

Yet another update.

Changed 11 years ago by John {at} Pullan {dot} {org}

Attachment: eitfixup5.patch added

Yet another update

comment:7 Changed 11 years ago by John {at} Pullan {dot} org

One more update!!

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup6.patch added

Another minor update

comment:8 Changed 11 years ago by Stuart Auchterlonie

Status: assignedstarted

Changed 11 years ago by John {at} Pullan {dot} org

Attachment: eitfixup7.patch added

comment:9 Changed 11 years ago by John {at} Pullan {dot} org

This patch to the base code strips the trailing white space from the eit entries, also prevents time events being split across subtitle/description and also adds another entry to the "New episode" (eitfixup7.patch)

Changed 11 years ago by John {at} Pullan {dot} org

Attachment: eitfixup8.patch added

Further updates

comment:10 Changed 11 years ago by John {at} Pullan {dot} org

eitfixup8.patch

Added code to remove "Series" subtitles

Removed slightly broken code for the CBBC/CBeebies

Changed 11 years ago by John {at} Pullan {dot} org

Attachment: eitfixup9.patch added

Update of file

comment:11 Changed 11 years ago by John {at} Pullan {dot} org

Fixed snafu with episode numbers (not being removed)

Remove "BBC4 on BBC TWO" type things

Improved (hopefully), the removal of "New"

comment:12 Changed 11 years ago by Stuart Auchterlonie

(In [15334]) Refs #4327. Another UK EIT fixup update from JohnP. This is based upon his eitfixup8 patch with a few bits from eitfixup9 to fix a problem where the titles were being completely blatted. I've also added a check to make sure that the partnumber is not greater than the parttotal. This stops things like 24/7 being caught as a partnumber/parttotal.

Changed 11 years ago by John {at} Pullan {dot} org

Attachment: eitfixup10.patch added

update of patch

Changed 11 years ago by John {at} Pullan {dot} org

Attachment: eitfixup11.patch added

update of patch

comment:13 Changed 11 years ago by John {at} Pullan {dot} org

Took out the code which was confusing : and -

Also fixed a problem where "1983:" was activating too soon.

comment:14 Changed 11 years ago by Stuart Auchterlonie

(In [15408]) Refs #4327. UK fixup #11 from JohnP. Plus a few small changes by me.

comment:15 Changed 11 years ago by Stuart Auchterlonie

(In [15409]) Refs #4327. Fixes the series comparisons

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup12.patch added

Experimental fix for the EIT

comment:16 Changed 11 years ago by anonymous

Stuff include in this patch:

  • Implementation of "New." which seems to help with "New. Doc Martin ..."
  • Use of isMovie (not really accurate but it does help)
  • Removal of all sub title descriptions
  • Much greater use of SetUKSubtitle

Feel free to pick and choose, although I would recommend getting the "New." bit.

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup13.patch added

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup14.patch added

comment:17 Changed 11 years ago by anonymous

  • Added better subtitle detection
  • Added "emergency" repair for "-" titles. (if no subtitle, but has "-" use that)

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup15.patch added

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup16.patch added

Various fixes

comment:18 Changed 11 years ago by john {at} pullan {dot} org

Fixed a few things:

  • Fixed the "BBC 4 on BBC Two".
  • Combined a lot of the other removals.
  • Fixed issue of a subtitle ending up just containing dots.
  • Fixed issue of a Radio 5 Live not having the correct subtitle, due to it having a time in it.
  • Fixed the description being promoted to the subtitle.

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup17.patch added

comment:19 Changed 11 years ago by john {at} pullan {dot} org

Fixed minor problem with the episode numbers.

comment:20 Changed 11 years ago by Anduin Withers

Component: mythtveit

comment:21 Changed 11 years ago by Stuart Auchterlonie

Resolution: fixed
Status: startedclosed

(In [16013]) Closes #4327. Last of the UK EIT fixup changes.

Note: See TracTickets for help on using tickets.