Opened 12 years ago

Closed 8 years ago

#4328 closed Patch - Feature (Won't Fix)

support movable antennas with HD Home Run

Reported by: George Nassas <gnassas@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: MythTV - HDHomeRun Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch adds the ability to spin around an antenna when tuning HDHR devices. It's similar to the external channel changer script for SD recorders but two extra bits of info are passed to the script - the mpeg program number and the station's callsign. The idea here is you're going to be grepping into a table of channels and azimuths so you can have your choice of how to match. Callsign makes the most sense but whatever.

Because HDHRs share their settings classes with DVB recorders this option is also exposed for them. It might be useful for someone with DVB-T but I didn't want to mess around with DVBChannel::Tune without such a device to test with.

Attachments (4)

channelChange.patch (4.5 KB) - added by George Nassas <gnassas@…> 12 years ago.
channelChange.15174.patch (4.5 KB) - added by George Nassas <gnassas@…> 12 years ago.
updated to apply after a recent MingGW change
hdhr.myth.v0.25pre-2256-g4d4eaa8.mythtv.patch (4.1 KB) - added by gnassas@… 8 years ago.
Current as of June 13
hdhr.myth.v0.25pre-2728-gc803867.mythtv.patch (3.8 KB) - added by gnassas@… 8 years ago.
VERBOSE -> LOG change broke the prior patch

Download all attachments as: .zip

Change History (13)

Changed 12 years ago by George Nassas <gnassas@…>

Attachment: channelChange.patch added

Changed 12 years ago by George Nassas <gnassas@…>

Attachment: channelChange.15174.patch added

updated to apply after a recent MingGW change

comment:1 Changed 12 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newassigned
Version: unknownhead

comment:2 Changed 11 years ago by danielk

Type: patchenhancement

comment:3 Changed 11 years ago by George Nassas <gnassas@…>

A P.S. to this: when I wrote the patch I didn't know the multirec branch had new code to rotate antennae. At some point I plan to go back and make the HDHR work with the that stuff and submit a revised patch. Probably in the 1-2 month timeframe.

comment:4 Changed 11 years ago by danielk

Resolution: invalid
Status: assignedclosed

George, I'm going to close this. Please reopen when your patch is ready.

comment:5 Changed 8 years ago by george Nassas <gnassas@…>

Resolution: invalid
Status: closednew

Lets see if I get the award for longest interval between ticket comments.

This updated patch is mostly straitforward but I want to call out the change to DTVChannel::SetChannelByString? where currently the channel change script is being used in lieu of tuning but I rework it to become part of tuning process. Well, not for S-Video and Composite inputs which continue the old way but digital streams are affected which is the point of the enhancement.

With this I'm not sure how things will shake out for firewire & I don't have such a creature to test against so I only note a possible problem.

I haven't included any UI elements but if you want 'em I'll make some.

Changed 8 years ago by gnassas@…

Current as of June 13

Changed 8 years ago by gnassas@…

VERBOSE -> LOG change broke the prior patch

comment:6 Changed 8 years ago by gnassas@…

Don't think this patch is high up on the list for reviews but just in case I want to call a hold or even close on it. The rec2 merge broke the logic and I haven't had a chance to look at it & who knows when I will.

comment:7 Changed 8 years ago by stuartm

Component: mythtvMythTV - HDHomeRun
Type: enhancementPatch - Feature
Version: headMaster Head

comment:8 Changed 8 years ago by George Nassas <gnassas@…>

Hmph, I was just thinking about posting a comment to this ticket to close it as it's now pretty easy to control a rotor through via script attached to the RecStarted? event.

It's better than code too, a while ago I switched my rotor input from an HDHR to an HVR-1600 and only had to touch the script's cardID test. System events has to be one of the all-time great changes!

comment:9 Changed 8 years ago by danielk

Resolution: Won't Fix
Status: newclosed

Thanks for the ping George

Note: See TracTickets for help on using tickets.