Opened 14 years ago

Closed 14 years ago

#4335 closed defect (fixed)

Mythgallery double scaling images

Reported by: stuartm Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythgallery Version: head
Severity: medium Keywords:
Cc: Ticket locked: no


When thumbnails are cached they are scaled to the correct size, yet IconView::LoadThumbnail?() is running smoothScale on them again after they are retrieved from the cache. This is unnecessary overhead.

Attached patch fixes this, but is untested. I stumbled across the problem while trying to figure out why alpha on thumbnails was being ignored.

Even further scaling seems to occur in IconView::UpdateView? but I couldn't tell whether this was also unnecessary at first glance.

Attachments (1)

mythgallery_scaleonce.diff (584 bytes) - added by stuartm 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by stuartm

Attachment: mythgallery_scaleonce.diff added

comment:1 Changed 14 years ago by danielk

Owner: changed from Isaac Richards to stuartm
Status: newassigned

comment:2 Changed 14 years ago by stuartm

Status: assignedaccepted

comment:3 Changed 14 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [15791]) Remove redundant scaling code from IconView::LoadThumbnail?(). Since we already scale the thumbnail when creating and caching it, it's not necessary to do so again after loading it.

Closes #4335

Note: See TracTickets for help on using tickets.