Opened 14 years ago

Closed 14 years ago

#436 closed defect (fixed)

gcc4 compile warnings list & some fixes (not including non-virtual destructor warnings)

Reported by: agforsyth@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: warning, gcc4
Cc: Ticket locked: no

Description

Most of these warning have to do with unused parameters, but a few are other things. Two fixes are noted. I thought it would be good to have a list.

In mythtv:
videoout_xv.cpp:826: warning: unused parameter ‘test_surface’
mythuiimage.cpp:189: warning: unused parameter ‘clipRect’
mythuitext.cpp:114: warning: unused parameter ‘clipRect’
themedmenu.cpp:2299: warning: unused parameter ‘clipRect’
filter_postprocess.c:57: warning: pointer targets in passing argument 7 of ‘pp_postprocess’ differ in signedness
filldata.cpp:872: warning: ‘chanid’ may be used uninitialized in this function
filldata.cpp:2170: warning: ‘chanid’ may be used uninitialized in this function
filldata.cpp:2170: warning: ‘mplexid’ may be used uninitialized in this function


To fix filter_postprocess.c:
edit libs/libavcodec/libpostproc/postprocess.h:
change #define QP_STORE_T int8_t
to #define QP_STORE_T uint8_t


In mythplugins:
mythcontrol:
mythcontrols.cpp:307: warning: unused parameter ‘item’
mythcontrols.cpp:315: warning: unused parameter ‘item’
mythcontrols.cpp:351: warning: unused parameter ‘context’

mythgame:
rom_metadata.cpp:17: warning: unused parameter ‘RomName?
rom_metadata.cpp:17: warning: unused parameter ‘GameType?
rom_metadata.cpp:24: warning: unused parameter ‘CRC32’
rom_metadata.cpp:24: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:34: warning: unused parameter ‘CRC32’
rom_metadata.cpp:34: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:44: warning: unused parameter ‘CRC32’
rom_metadata.cpp:44: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:54: warning: unused parameter ‘CRC32’
rom_metadata.cpp:54: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:65: warning: unused parameter ‘CRC32’
rom_metadata.cpp:65: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:76: warning: unused parameter ‘CRC32’
rom_metadata.cpp:76: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:87: warning: unused parameter ‘CRC32’
rom_metadata.cpp:87: warning: unused parameter ‘GameTitle?
rom_metadata.cpp:98: warning: unused parameter ‘CRC32’
rom_metadata.cpp:98: warning: unused parameter ‘GameTitle?

mythmusic:
/usr/include/cdda/cdda_interface.h:195: warning: ‘strerror_tr’ defined but not used
/usr/include/cdda/cdda_interface.h:195: warning: ‘strerror_tr’ defined but not used
/usr/include/cdda/cdda_interface.h:195: warning: ‘strerror_tr’ defined but not used
goom/goom_core.c:659: warning: pointer targets in passing argument 1 of ‘tentacle_update’ differ in signedness
goom/goom_core.c:659: warning: pointer targets in passing argument 2 of ‘tentacle_update’ differ in signedness
goom/goom_core.c:661: warning: pointer targets in passing argument 1 of ‘tentacle_update’ differ in signedness
goom/goom_core.c:661: warning: pointer targets in passing argument 2 of ‘tentacle_update’ differ in signedness


to fix goom_core.c:
edit mythmusic/mythmusic/goom/tentacle3d.h:
change void tentacle_update(int *buf, int *back,
to void tentacle_update(uint *buf, uint *back,


Attachments (1)

mythtv.gcc4.warnings.patch (982 bytes) - added by agforsyth@… 14 years ago.
Patch that fixes the "differ in signedness" warnings above.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by agforsyth@…

Attachment: mythtv.gcc4.warnings.patch added

Patch that fixes the "differ in signedness" warnings above.

comment:1 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [7419]) Fix a couple random warnings, close #436.

Not fixing the goom warning, since that's external code. Not fixing the majority of the 'unused parameter' warnings, as those are mainly unfinished code.

comment:2 Changed 14 years ago by anonymous

Resolution: fixed
Status: closedreopened

r7419 did NOT fix the warning in filterpostprocess.cpp: made type (signed char *) which it already was, needs to be (unsigned char *).

comment:3 Changed 14 years ago by anonymous

Resolution: fixed
Status: reopenedclosed

Never mind. I mistyped "make clean" and didn't notice. (Saturday night, what do you expect?)

Note: See TracTickets for help on using tickets.