Opened 11 years ago

Closed 11 years ago

#4372 closed defect (fixed)

UPnP and UTF-8 fixes

Reported by: otto at kolsi dot fi Owned by: stuartm
Priority: minor Milestone: 0.21.1
Component: upnp Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Mythbackend/UPnP returns recording, music and video information without correct UTF-8 conversions in place. Attached patch fixes couple of places so that e.g. song and recording names are returned correctly.

With this patch in place there still are following places that gets corrupted if there are non-ascii characters:

  • when browsing music By Album, the album name is still corrupted
  • when browsing recordings By Title, when title is in container/directory name it is corrupted but when that directory is opened, same name is okay in filename
  • when browsing recordings By Group the group name / directory name is still corrupted

These are all cases where corruption occurs in container/directory name. This should be easy to fix by someone with more knowledge of the code.

Attachments (3)

upnp-utf8.patch (3.5 KB) - added by otto at kolsi dot fi 11 years ago.
upnp_utf8_fixes.diff (25.1 KB) - added by stuartm 11 years ago.
upnp-utf8-v2.patch (633 bytes) - added by otto at kolsi dot fi 11 years ago.

Download all attachments as: .zip

Change History (17)

Changed 11 years ago by otto at kolsi dot fi

Attachment: upnp-utf8.patch added

comment:1 Changed 11 years ago by stuartm

Owner: changed from dblain to stuartm
Status: newaccepted

comment:2 Changed 11 years ago by stuartm

(In [15241]) UTF8 conversion fixes for the upnp code, patch by Otto Kolsi.

Refs #4372

comment:3 Changed 11 years ago by stuartm

Status: acceptedstarted

comment:4 Changed 11 years ago by stuartm

Milestone: unknown0.21

comment:5 Changed 11 years ago by stuartm

Type: patchdefect

Changed 11 years ago by stuartm

Attachment: upnp_utf8_fixes.diff added

comment:6 Changed 11 years ago by stuartm

Status: startedinfoneeded

Attached a patch with additional utf8 fixes for music and video (some whitespace fixes slipped in too). Could you test the patch and let me know if anything remains to be fixed and whether it breaks anything that used to work?

comment:7 Changed 11 years ago by stuartm

Resolution: fixed
Status: infoneededclosed

(In [16115]) UTF8 fixes for upnp, closes #4372

comment:8 Changed 11 years ago by stuartm

(In [16116]) Merge [16114], [16115] to 0.21-fixes. UTF8 fixes mostly, with some whitespace cleanup. Fixes #4372

comment:9 Changed 11 years ago by otto at kolsi dot fi

Resolution: fixed
Status: closednew

There are still following UTF-8 problems:

When recordings are browsed, if recording "directory/folder" contains non-ascii characters it gets corrupted. At the same time all the program titles are fine so this only affects containers/folders/directories (don't know what is the correct term). Problem occurs in several places, when browsing By Title and By Group.

Exactly same happens when browsing music, directory names (album names) are corrupted but song titles are fine.

With Videos, the same issue seems a bit worse. I have only one UPnP client (Nokia N95) and that refuses to open (shows an error) directory that contains non-ascii characters. Since Video-directories are directly read from the filesystem it is possible that I have non-ascii characters in wrong format in video directory names.

comment:10 Changed 11 years ago by stuartm

Owner: changed from stuartm to Isaac Richards
Status: newassigned

comment:11 Changed 11 years ago by stuartm

Owner: Isaac Richards deleted
Status: assignednew

Changed 11 years ago by otto at kolsi dot fi

Attachment: upnp-utf8-v2.patch added

comment:12 Changed 11 years ago by otto at kolsi dot fi

I've attached upnp-utf8-v2.patch which fixes the UTF-8 problem in Music and Recordings (corruption of album titles and recording names). Patch is against 0.21-fixes.

Videos still have some problems but that might be related to filesystem / environment issues as mentioned earlier in this ticket.

comment:13 Changed 11 years ago by stuartm

Owner: set to stuartm
Status: newaccepted

comment:14 Changed 11 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [18429]) Utf8 fix for videos with upnp. Closes #4372

Note: See TracTickets for help on using tickets.