Opened 12 years ago

Closed 12 years ago

#4373 closed patch (fixed)

Use 64-bit offset type in dvd_input.c (libmythdvdnav)

Reported by: andrei@… Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

off_t is 32-bit on some platforms (Windows), which breaks DVD playback (tested with DVD ISO image).

The patch proposes use of off64_t and lseek64 instead of off_t and lseek, which is posix-compatible and should work on all platforms.

Attachments (1)

dvdinput.patch (518 bytes) - added by andrei@… 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by andrei@…

Attachment: dvdinput.patch added

comment:1 Changed 12 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newassigned

comment:2 Changed 12 years ago by andrei@…

Please review this patch. I tested it on Win32 (where it's required) and Linux (where it doesn't really change anything, only clarifies that it is in fact requires 64-bit offsets), it does not introduce any side effects.

comment:3 Changed 12 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [15624]) Fixes #4373. Use lseek64() rather than lseek() for MINGW compatibility.

Note: See TracTickets for help on using tickets.