Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4399 closed patch (fixed)

Reorganise plugins widescreen themes (source)

Reported by: Roo <roo.watt@…> Owned by: Anduin Withers
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords: reorganise wide screen theme
Cc: Ticket locked: no

Description

Attached is a "patch" (actually a shell script) that reorganises the widescreen theme for mythplugins as discussed on IRC.

Running the shell script on a pristine working copy will perform the moves, deletes and adds etc without committing them. This seemed preferable to providing a tarred wc due to the size of it. :)

There is a README that has instructions on applying/using the script.

At present most widescreen theme files are in mythtv/themes/default-wide and the 4:3 themes are in the plugin source tree.

This patch moves the wide theme files into a predictable location within the appropriate plugin source tree.

There is no change to the installed locations of the files, in fact the patch was tested by comparing directory listings for the installed files before and after.

Attachments (3)

reorganise-themes_v1_r15270.tgz (9.6 KB) - added by Roo <roo.watt@…> 12 years ago.
Version 1 against r15270
reorganise-themes_v2_r15270.tgz (9.8 KB) - added by Roo <roo.watt@…> 12 years ago.
update for a couple of missed .png in mythtv/themes/default-wide
reorganise-themes_v3_r15381.tar.gz (14.0 KB) - added by Roo <roo.watt@…> 12 years ago.

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by Roo <roo.watt@…>

Version 1 against r15270

Changed 12 years ago by Roo <roo.watt@…>

update for a couple of missed .png in mythtv/themes/default-wide

comment:1 Changed 12 years ago by Anduin Withers

(In [15352]) References #4399

The MythVideo? part of #4399, just reorganization and bumping themedummy.c to mythplugins for reuse. Also split UI and image files.

comment:2 Changed 12 years ago by Roo <roo.watt@…>

V3 - Adding an updated patch that allows the plugins to be updated individually. Just select which plugins you want to update.

Removes mythvideo from the plugins as it was updated and adds mythappearance as it is a new plugin.

I have tweaked the .pro file based on awithers changes for [15352].

Changed 12 years ago by Roo <roo.watt@…>

comment:3 Changed 12 years ago by Anduin Withers

Owner: changed from Isaac Richards to Anduin Withers
Status: newassigned

comment:4 Changed 12 years ago by Anduin Withers

Milestone: 0.210.22

If a plug-in maintainer wants to apply this before the 0.21 release feel free, otherwise I'll apply it to all unmaintained plug-ins after the 0.21 release.

comment:5 Changed 12 years ago by Anduin Withers

Resolution: fixed
Status: assignedclosed

(In [16948]) Closes #4399

Reorganize the directory layout for plugins.

New layout:

plugin/theme/default plugin/theme/default-wide plugin/theme/menus

Images belonging exclusively to a plugin are now owned by that plugin.

Many thanks to Roo who did all this.

Note: only file moves and necessary .pro changes.

comment:6 Changed 12 years ago by Anduin Withers

(In [16952]) References #4399

Fix a bug introduced in [16948] images need to be in theme/default(-wide)/images.

Note: See TracTickets for help on using tickets.