Opened 12 years ago

Closed 12 years ago

#4411 closed patch (fixed)

changeset 15290 is incompatible with Win32

Reported by: andrei@… Owned by: Isaac Richards
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch essentially disables inclusion of chahgeset 15290 in Win32 builds, it's not compatible with Win32.

Attachments (1)

themereload_win32.patch (1.1 KB) - added by andrei@… 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by andrei@…

Attachment: themereload_win32.patch added

comment:1 Changed 12 years ago by David Bussenschutt (aka buzz) <davidbuzz@…>

+1 from me - patch works well on Win32.

comment:2 Changed 12 years ago by Nigel

What is the error in MinGW? I only ask because the ::sigBlah() syntax causes a compile problem on Mac OS X (GCC 4.0.1):

cd mythfrontend && /usr/bin/make -f Makefile
g++ -c -pipe -march=pentium4 -fomit-frame-pointer -O3 -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -Wno-non-virtual-dtor -D__STDC_CONSTANT_MACROS -Wno-long-double  -DMMX -Di386 -DUSING_APPLEREMOTE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DPREFIX=\"/Volumes/MythBuild/.osx-packager/build\" -DLIBDIR=\"/Volumes/MythBuild/.osx-packager/build/lib\" -DUSING_COREAUDIO -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -DQT_SHARED -DQT_ACCESSIBILITY_SUPPORT -I/Volumes/MythBuild/.osx-packager/build/mkspecs/default -I. -I../../../../../build/include -I../../../../../build/include -I../.. -I../../libs -I../../libs/libmyth -I../../libs/libmythtv -I../../libs/libavutil -I../../libs/libavformat -I../../libs/libavcodec -I../../libs/libmythupnp -I../../libs/libmythui -I../../libs/libmythlivemedia -I/Volumes/MythBuild/.osx-packager/build/include -I/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers -I/System/Library/Frameworks/AGL.framework/Versions/A/Headers -o main.o main.cpp
main.cpp: In function 'int main(int, char**)':
main.cpp:1427: error: expected id-expression before '(' token
make[2]: *** [main.o] Error 1
make[1]: *** [sub-mythfrontend] Error 2

and I will have to commit a fix for that soon.

comment:3 Changed 12 years ago by andrei@…

MinGW does not support sigaction() at all. There are other ways for interprocess communication in Win32, but as far as I can tell, none of them can be easily translated to compatible code.

comment:4 Changed 12 years ago by greg

Resolution: fixed
Status: newclosed

(In [15335])

Changes USR1 signal handler code to use the same signal() routine

already used for -HUP. Should compile on OSX and Win32 as well since they are already compiling with the existing code.

Closes #4411

Note: See TracTickets for help on using tickets.