Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#4420 closed defect (fixed)

this==0 in ringbuffer

Reported by: michael bishop <clever@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no


#0 0xb77f892f in RingBuffer::InDVDMenuOrStillFrame (this=0x0) at RingBuffer?.cpp:1343 #1 0xb7a4de82 in TV::ProcessKeypress? (this=0xa7469000, e=0xaad2ab18) at tv_play.cpp:3004

was changing the volume level while the bandwidth to the mysql server was maxed out

Attachments (1)

4420.txt (1.0 KB) - added by anonymous 14 years ago.

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by anonymous

Attachment: 4420.txt added

comment:1 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [15319]) Fixes #4420. The actual segfault reported in the ticket no longer exists in svn trunk, but this changeset makes sure we always check for a null ringbuffer shortly before checking the InDVDMenuOrStillFrame state.

PS The backtrace was only partial and matched neither svn trunk nor 0.20-fixes so I couldn't trace down where exactly the null pointer was used in tv_play, but the partial stacktrace did tell me the functions involved and this fixes all the InDVDMenuOrStill() calls in the TV class...

comment:2 Changed 14 years ago by michael bishop <clever@…>

one of the changed lines nearly duplicated the patch i made(i had more ()'s)
but when i was going to submit that last night the site stoped loading

Note: See TracTickets for help on using tickets.