Opened 12 years ago

Closed 12 years ago

#4429 closed defect (fixed)

Mythmusic DBError reported when importing a CD

Reported by: Roo <roo.watt@…> Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

[15223] makes sure that the compilation flag is updated when metadata is updated.

The numRowsAffected check is causing a DBError to be reported if the UPDATE did not affect/change any rows.

As per: ​http://doc.trolltech.com/3.3/qsqlquery.html#numRowsAffected 

If the query is not active (isActive() returns FALSE), -1 is returned.
So it seems the simple fix is to remove the "
query.numRowsAffected() <= 0" test.

Attached is a patch to do just that.

Attachments (1)

mythmusic_numRowsAffected.diff​ (540 bytes) - added by Roo <roo.watt@…> 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by Roo <roo.watt@…>

Attachment: mythmusic_numRowsAffected.diff​ added

comment:1 Changed 12 years ago by paulh

Owner: changed from Isaac Richards to paulh
Status: new → assigned

comment:2 Changed 12 years ago by paulh

Resolution: → fixed
Status: assigned → closed

(In [15350]) Don't assume there was a DB error when updating the compilation flag and no record was updated.

What can happen is that if no field values are changed the query reports that no records were affected even though the query executed with no problems.

Patch by Roo. Fixes #4429.

Note: See TracTickets for help on using tickets.