Opened 13 years ago
Closed 13 years ago
#4429 closed defect (fixed)
Mythmusic DBError reported when importing a CD
Reported by: | Owned by: | paulh | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythmusic | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
[15223] makes sure that the compilation flag is updated when metadata is updated.
The numRowsAffected check is causing a DBError to be reported if the UPDATE did not affect/change any rows.
As per: http://doc.trolltech.com/3.3/qsqlquery.html#numRowsAffected
If the query is not active (isActive() returns FALSE), -1 is returned.
query.numRowsAffected() <= 0" test. |
Attached is a patch to do just that.
Attachments (1)
Change History (3)
Changed 13 years ago by
Attachment: | mythmusic_numRowsAffected.diff added |
---|
comment:1 Changed 13 years ago by
Owner: | changed from Isaac Richards to paulh |
---|---|
Status: | new → assigned |
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [15350]) Don't assume there was a DB error when updating the compilation flag and no record was updated.
What can happen is that if no field values are changed the query reports that no records were affected even though the query executed with no problems.
Patch by Roo. Fixes #4429.