Opened 12 years ago

Closed 12 years ago

#4430 closed enhancement (wontfix)

Mythmusic Rip Directory

Reported by: Roo <roo.watt@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords: rip directory
Cc: Ticket locked: no

Description

This patch enables a configurable rip directory for mythmusic.

There area number of reasons for having a configurable rip dir. However the main reason is that if mythmusic is extended to allow multiple music directories (like mythvideo) then it would be desirable to specify which dir tracks got ripped to.

The patch does not check to see if the rip dir is accessible from the music dir (subdir, symlinks etc).

This means the newly ripped tracks will be added to the DB even if they are not accessible for playback. A rescan will fix this if it is a problem.

I don't see this as a problem as it doesn't make much sense to use mythmusic to rip tracks but not for playback.

Attachments (1)

mythmusic_rip_directory_v1_r15332.diff (4.8 KB) - added by Roo <roo.watt@…> 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Roo <roo.watt@…>

comment:1 Changed 12 years ago by paulh

I'm not sure about this one. I think it will just confuse people having two different settings. They could easily end up ripping there music to somewhere that isn't accessible to the player, that is not in the normal music path, and will wonder why they can't play their newly ripped tracks.

If we ever do allow multiple music directories then we will have to re-think things but until then is there any use for this?

comment:2 in reply to:  1 Changed 12 years ago by Roo <roo.watt@…>

Replying to paulh:

I'm not sure about this one. I think it will just confuse people having two different settings. They could easily end up ripping there music to somewhere that isn't accessible to the player, that is not in the normal music path, and will wonder why they can't play their newly ripped tracks.

Fair enough.

If we ever do allow multiple music directories then we will have to re-think things but until then is there any use for this?

Having thought further about it, if/when multiple dirs are supported maybe the first dir in the list could be used to rip to and the remaining dirs just for playback. That is essentially what is happening now anyway, without the extra dirs.

My current use case is to keep the tracks I rip now (using flac) separate from the old ones ripped using ogg. I intend to re-rip using flac, so it just helped there.

I am happy for you to close this ticket.

comment:3 Changed 12 years ago by paulh

Resolution: wontfix
Status: newclosed

We'll look at this if and when MythMusic allows multiple directories until then I don't see a need for this.

Note: See TracTickets for help on using tickets.