Opened 12 years ago

Closed 11 years ago

#4434 closed patch (fixed)

Have JUMPPREV act as PREVCHAN in Live TV; delete PREVCHAN; fix #4433

Reported by: ylee@… Owned by: cpinkham
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords: prevchan jumpprev previous channel program keybinding
Cc: Ticket locked: no

Description

The attached patch for 0.20.2 does three things:

  • Delete the PREVCHAN binding. It is now useless, because . . .
  • . . . The JUMPPREV binding now perform two functions, depending on the context: 1) As always, jump to the previous recording (when not in Live TV mode), and 2) jump to the previous channel (in Live TV).
  • Along the way, fix the bug with JUMPPREV I describe in #4433.

Why I wrote this: I have a PREV CH button on my remote, bound to 'H'. Without this patch, and with the default keybindings, PREV CH jumps to the previous channel in Live TV (PREVCHAN) but does nothing when watching a recording (JUMPPREV). If I assign the same binding to both functions, JUMPPREV works but PREVCHAN doesn't. With this patch, I can now use one button for both functions.

I realize that it's not common practice to include in a non-SVN release a patch that's not purely a bugfix, but a) perhaps it'll be of some use to the developers for SVN and b) perhaps other 0.20.x users will find it useful.

Attachments (1)

patch-prevchan.cpp (4.3 KB) - added by ylee@… 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by ylee@…

My apologies; I uploaded the wrong patch! Admins, please delete patch-ThreadedFileWriter?.cpp.

Changed 12 years ago by ylee@…

Attachment: patch-prevchan.cpp added

comment:2 Changed 11 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham
Status: newassigned

comment:3 Changed 11 years ago by cpinkham

Milestone: unknown0.21

comment:4 Changed 11 years ago by danielk

Version: 0.20.2head

comment:5 Changed 11 years ago by cpinkham

Resolution: fixed
Status: assignedclosed

(In [15795]) Allow the PREVCHAN keybinding to act the same as JUMPPREV while watching a normal recording.

Closes #4434, but applies a different patch and almost reverse logic.

The patch in the ticket removed PREVCHAN and made JUMPPREV serve double-duty making it go to the previous channel in LiveTV and the previous program while watching a recording. This would have lost functionality though, because it is a valid action to jump from LiveTV to a previous recording.

This patch allows the user to map only PREVCHAN if they want to and use it in LiveTV to jump to the previous channel and use the same key to jump back to the previous recording when watching a recording. It does not prevent the user from mapping both PREVCHAN and JUMPPREV to different keys, it does allow both to be used to jump to the previous recording when not in LiveTV.

Note: See TracTickets for help on using tickets.