Opened 12 years ago

Closed 12 years ago

#4439 closed patch (invalid)

sprintf -> snprintf under WIn32

Reported by: David Bussenschutt <davidbuzz@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

PROBLEM:

./mpegts.o: In function `dlerror': c:/mythtv/mythtv/libs/libavformat/../libmyth/compat.h:205: undefined reference to `sprintf_is_forbidden_due_to_security_issues_use_snprintf' collect2: ld returned 1 exit status

Attachments (2)

snprintf_win32.patch (961 bytes) - added by David Bussenschutt <davidbuzz@…> 12 years ago.
fixes issue with sprintf on Win32 by replacing with snprintf
snprintf_win32_LF.patch (961 bytes) - added by David Bussenschutt <davidbuzz@…> 12 years ago.
same file, but with Unix line terminators to keep trac happy.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by David Bussenschutt <davidbuzz@…>

Attachment: snprintf_win32.patch added

fixes issue with sprintf on Win32 by replacing with snprintf

Changed 12 years ago by David Bussenschutt <davidbuzz@…>

Attachment: snprintf_win32_LF.patch added

same file, but with Unix line terminators to keep trac happy.

comment:1 Changed 12 years ago by David Bussenschutt <davidbuzz@…>

sorry guys.. either of these is equivalent, I don't know why trac fails to render the unified diff properly when viewed in a browser, I though it was the line terminators, but it appears not to be. anyone?

comment:2 Changed 12 years ago by jaymode@…

Is this not fixed in r15356?

About the trac reason for the patch, normally the .patch files are in a different format with '-' and '+' and not really any '!' in them(at least from what I have seen)

comment:3 Changed 12 years ago by David Bussenschutt <davidbuzz@…>

So it is, I was just running a tiny bit behind HEAD . sorry forthe noise. lest call this closed/cancelled?

comment:4 Changed 12 years ago by Nigel

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.