id,summary,reporter,owner,description,type,status,priority,milestone,component,version,severity,resolution,keywords,cc,mlocked 4449,Fix recgroup_select() for Advanced Options,sphery ,xris,"The attached patch, mythweb-recgroup_select-this_group.patch , fixes two issues in recgroup_select(). Without the patch, I get the following output when trying to create a new schedule (where $this_group is passed in as the empty string):
In my record table I have recgroups Default, Science, and Half-hour Shows. In recorded, I have the same three plus Movies. Since the ""catch-all"" (!$groups[$this_group]) conditional uses $group for display instead of $this_group, Movies appears twice in the display values of the select box, and the second (and selected) one has the empty string as a value. However, since it makes more sense for the recording group to default to Default (if it's set to the empty string, the backend resets it to 'Default', anyway), I added an empty check and set $this_group to 'Default' at the beginning of the function. I did not translate the display value for 'Default', though it probably should be (I think it's supposed to be 'Default' in the DB and translated for display). Now to fix the recgroup of all the movies I've recorded recently... :)",patch,closed,minor,unknown,mythweb,head,medium,fixed,,,0