Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4483 closed patch (fixed)

segfault from tv_play

Reported by: michael bishop <clever@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

#1  0xb7a2f474 in NuppelVideoPlayer::SetCommBreakMap (this=0x0, newMap=@0xbf940210) at NuppelVideoPlayer.cpp:5717
#2  0xb7a061cc in TV::customEvent (this=0xb2a93638, e=0x9597898) at tv_play.cpp:5814
Index: tv_play.cpp
===================================================================
--- tv_play.cpp (revision 15422)
+++ tv_play.cpp (working copy)
@@ -5811,7 +5811,8 @@
                     newMap[mark[0].toInt()] = mark[1].toInt();
                 }

-                nvp->SetCommBreakMap(newMap);
+                if (nvp)
+                    nvp->SetCommBreakMap(newMap);
             }
         }
         pbinfoLock.unlock();

fixed this a few weeks ago on my master but forgot to submit it then it happened again on a slave

Change History (2)

comment:1 Changed 12 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [15463]) Fix a segfault in TV::customEvent() that would happen if TV received a COMMFLAG_UPDATE event before it had a chance to instantiate a NuppelVideoPlayer?.

Closes #4483 but uses a different fix than the one in the ticket.

comment:2 Changed 12 years ago by cpinkham

(In [15464]) Carry over [15463] from trunk.

Fix a segfault in TV::customEvent() that would happen if TV received a COMMFLAG_UPDATE event before it had a chance to instantiate a NuppelVideoPlayer?.

References #4483.

Note: See TracTickets for help on using tickets.