Opened 12 years ago

Closed 12 years ago

#4497 closed patch (fixed)

Win32 builds broken after r15435

Reported by: Jay Modi <jaymode@…> Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords: win32 mingw
Cc: Ticket locked: no

Description

The Win32 builds seem to have been partially broken by r15435. The first issue I noticed is that the typedef on line 89 needs a semicolon. However, this leads to even more problems, dealing with multiple definitions. The cure for this is to remove the typedef and then include compat.h but this causes linking errors. These linking errors are due to some other issue, as I have removed the entire r15435 changes from my compat.h and get the same errors.

I have attached a patch file to add the include.

Attachments (2)

util_win32.patch (345 bytes) - added by Jay Modi <jaymode@…> 12 years ago.
Patch to add include to util.h
remoteutil.patch (329 bytes) - added by Jay Modi <jaymode@…> 12 years ago.
Patch for libmythtv/remoteutils.cpp. Needs compat.h for usleep() in Win32

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by Jay Modi <jaymode@…>

Attachment: util_win32.patch added

Patch to add include to util.h

Changed 12 years ago by Jay Modi <jaymode@…>

Attachment: remoteutil.patch added

Patch for libmythtv/remoteutils.cpp. Needs compat.h for usleep() in Win32

comment:1 Changed 12 years ago by danielk

Milestone: unknown0.21
Owner: changed from Isaac Richards to danielk
Status: newassigned
Version: unknownhead

comment:2 Changed 12 years ago by Jay Modi <jaymode@…>

These patches may be unnecessary and it seems the builds actually broke with r15478. I believe the issue I was experiencing when I had opened the ticket was due to the use of a --cpu=k8 flag in the configure script, while using the win32-packager.pl script.

comment:3 Changed 12 years ago by danielk

Resolution: invalid
Status: assignedclosed

comment:4 in reply to:  3 Changed 12 years ago by jaymode@…

Resolution: invalid
Status: closednew

Replying to danielk: I was incorrect. r15435 does break the Win32 builds when sse and mmx are enabled. The --cpu flag needs to be specified due to the cpu auto detection in the configure script being broken(per Andrei Tanas) in order to enable sse and mmx. With the --cpu=k8 flag enabled, the util_win32.patch is needed. The remoteutil.patch should be ignored for now.

r15478 breaks the builds with this patch, but that is a separate issue.

comment:5 Changed 12 years ago by Nigel

(In [15547]) Prevent error on Windows builds when MMX is defined. See #4497

comment:6 Changed 12 years ago by danielk

Jay, what patches on this ticket are still relevant and why? I don't have a windows box, so I need a little direction here...

comment:7 Changed 12 years ago by Jay Modi <jaymode@…>

Neither patch is relevant. The remoteutil.patch is irrelevant and is not needed. The util_win32.patch has been applied by Nigel in r15547. So this ticket can be closed.

comment:8 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.