Opened 16 years ago
Closed 15 years ago
#4513 closed patch (fixed)
Greedy/Yadif deinterlacers override deinterlacing settings
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.22 |
| Component: | mythtv | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Both the greedy and yadif deinterlacers ignore progressive frames internally.
This ignores any user override and the operation of the 'autodeint' code. The main player code, as implemented, only calls the deinterlacing filter if it actually wants the frame deinterlaced.
So any stream that flips between progressive and interlaced frames or any stream for which the scan is mis-detected, the user cannot force greedy or yadif to deinterlace.
Patch attached.
Attachments (2)
Change History (10)
Changed 16 years ago by
| Attachment: | greedy_yadif.diff added |
|---|
comment:1 Changed 16 years ago by
| Milestone: | unknown → 0.21 |
|---|---|
| Owner: | changed from Isaac Richards to danielk |
| Status: | new → assigned |
comment:2 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:3 Changed 16 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
the fix was wrong. With this fix it was impossible to view progressive material cause each frame was delivered to the "double process" deints (save frame history) and deinterlaced by them.
I've done a better fix (attached) which uses the decision made by user and delivers them to the deint.
comment:4 Changed 16 years ago by
| Milestone: | 0.21 → 0.22 |
|---|
Moving to 0.22, Mark Kendall is looking at this..
comment:5 Changed 16 years ago by
Just FYI, I just applied the second patch from Markus on revision 16807 of the 0.21-fixes branch, and it seems to work great for me. I was seeing artifacts/jaggies on progressive video, and best I can tell now this video looks great and it no longer forcefully interlaced due to my using Greedy2H as the default deinterlacer.
comment:6 Changed 16 years ago by
There still seems to be a problem with the greedy/yadif 2x deinterlacers in 0.21-fixes - I see scaling artefacts on progressive content when these are enabled. The non-2x versions are fine however.
comment:7 Changed 15 years ago by
| Status: | new → assigned |
|---|
comment:8 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [19305]) Don't deinterlace progressive material when using 'doubleprocess' deinterlacers. Closes #4513.
N.B. The double process deinterlacers still decide internally which field to deinterlace. This breaks user overrides in certain situations and duplicates code with the main player. The fix for that, however, is more involved...
(In [15726]) Fixes #4513. A couple small tweaks to greedy/yadiff deinterlacers from Mark Kendall.