Opened 12 years ago

Closed 12 years ago

#4514 closed patch (fixed)

mythweb.pl only loads handler.pl once when using mod_perl

Reported by: sub@… Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

Because mod_perl reuses the same perl interpreter at times, the line

require "modules/$Path[0]/handler.pl";

only loads handler.pl once (the first time the code is reached), instead of every time the code is processes. As a result, calls after the first one yield nothing.

In addition, calling CORE::exit in handler.pl causes Apache to return an error. I recommend using a "goto" instead.

I'm attaching some recommended changes against Revision 15494.

Attachments (1)

mythweb.patch.txt (3.2 KB) - added by sub@… 12 years ago.
Patch for handler.pl/mythweb.pl

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by sub@…

Attachment: mythweb.patch.txt added

Patch for handler.pl/mythweb.pl

comment:1 Changed 12 years ago by Rob Smith

FYI Sub, attaching patches with an extention of .diff or .patch causes them to be displayed really nicely and allows quick auditing much easier.

comment:2 Changed 12 years ago by xris

Actually, I can't do this. The whole reason for the CORE::exit call was because apache/mod_perl holds onto the stream process (in this case ffmpeg) even if the browser closes the session early, which eats up RAM and CPU resources.

However, after seeing your requested changes and realizing this, I've decided that the mod_perl code isn't ready for proper release, so I'll be removing it shortly.

comment:3 Changed 12 years ago by xris

Resolution: fixed
Status: newclosed

(In [16074]) vaguely related to #4514, remove all mod_perl references because this handler, and the streaming setup in general, aren't quite ready to work with mod_perl. closes #4514

Note: See TracTickets for help on using tickets.